Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOOLS-2525 Everything needs to stop cloning with git:// URLs (dependencies) #5

Merged
merged 1 commit into from Mar 27, 2022

Conversation

bahamat
Copy link
Member

@bahamat bahamat commented Mar 25, 2022

cloudapi depends on this

@bahamat
Copy link
Member Author

bahamat commented Mar 25, 2022

make test passes with the new version

$ make test
TAP=1 ./node_modules/.bin/tap test/*.test.js
TAP version 13
# api.test.js
# TAP version 13
# load test keys into UFDS, initialized keyapi
ok 1 (unnamed assert)
ok 2 (unnamed assert)
# {"name":"test","hostname":"Pepper.local","pid":29379,"component":"ufds","level":30,"msg":"LDAP client disconnected","time":"2022-03-25T18:39:37.061Z","v":0}
# token/detoken round-trip (with stubs)
ok 3 (unnamed assert)
ok 4 should be equal
ok 5 should be equal
ok 6 (unnamed assert)
ok 7 (unnamed assert)
ok 8 (unnamed assert)
ok 9 should be equivalent
# token/detoken round-trip (without stubs)
ok 10 (unnamed assert)
ok 11 should be equal
ok 12 should be equal
ok 13 (unnamed assert)
ok 14 (unnamed assert)
ok 15 (unnamed assert)
ok 16 should be equivalent
# will only tokenize objects
ok 17 should be equal
ok 18 (unnamed assert)
# token/detoken round-trip (without superfluous JSON)
ok 19 (unnamed assert)
ok 20 should be equal
ok 21 should be equal
ok 22 (unnamed assert)
ok 23 (unnamed assert)
ok 24 (unnamed assert)
ok 25 should be equivalent
# clear test keys from UFDS
ok 26 (unnamed assert)
ok 27 (unnamed assert)
# {"name":"test","hostname":"Pepper.local","pid":29379,"component":"ufds","level":30,"msg":"LDAP client disconnected","time":"2022-03-25T18:39:37.718Z","v":0}
# {"name":"test","hostname":"Pepper.local","pid":29379,"component":"ufds","level":30,"msg":"LDAP client disconnected","time":"2022-03-25T18:39:38.631Z","v":0}
# keyapi should save new key to UFDS if there was none
ok 28 (unnamed assert)
ok 29 should be equal
ok 30 (unnamed assert)
# tests 30
# pass  30
# ok
ok 31 test/api.test.js


1..31
# tests 31
# pass  31

# ok

@bahamat
Copy link
Member Author

bahamat commented Mar 27, 2022

As an added note, the only significant change here is sdc-securetoken, and the only change in the diff between the versions is adding license info (the previous commit actually predates opening SDC), switching to engbld, and a few housekeeping tasks related to engbld. No actual changes to how the securetoken module itself works. So that change should effectively be a NOP, except for no longer using git:// URLs.

@bahamat bahamat merged commit bedd6fe into master Mar 27, 2022
@bahamat bahamat deleted the TOOLS-2525 branch March 27, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants