Skip to content
This repository has been archived by the owner. It is now read-only.
Permalink
Browse files

unix: fix assertion failure when the signal pipe overflows

An incorrect assert() statement was causing libuv to crash when writing
to an internal signal pipe would result in EAGAIN/EWOULDBLOCK.

This commit doesn't solve the underlying issue that the signal pipe can
overflow.

This should fix nodejs/node-v0.x-archive#5538
  • Loading branch information...
piscisaureus committed May 23, 2013
1 parent c53fe81 commit 9df9b5d1e86f7cea7c0ab3e73ce54ae1db3fc7c1
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/unix/signal.c
@@ -160,7 +160,7 @@ static void uv__signal_handler(int signum) {
} while (r == -1 && errno == EINTR);

assert(r == sizeof msg ||
(r == -1 && errno != EAGAIN && errno != EWOULDBLOCK));
(r == -1 && (errno == EAGAIN || errno == EWOULDBLOCK)));

if (r != -1)
handle->caught_signals++;

0 comments on commit 9df9b5d

Please sign in to comment.
You can’t perform that action at this time.