unix: don't abort() on EINVAL in threadpool.c

The FreeBSD implementation of pthread_join() returns EINVAL when a thread has already quit, not ESRCH.
joyent · Oct 6, 2012 · b9ed1a6 · b9ed1a6
1 parent b152b12
commit b9ed1a6
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/unix/threadpool.c b/src/unix/threadpool.c
@@ -101,11 +101,8 @@ static void cleanup(void) {
 
   for (i = 0; i < ARRAY_SIZE(threads); i++) {
     err = pthread_join(threads[i], NULL);
-
+    assert(err == 0 || err == EINVAL || err == ESRCH);
-    if (err == 0 || err == ESRCH)
+    (void) err; /* Silence compiler warning in release builds. */
-      continue;
-
-    abort();
   }
 }