Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

Fix a couple warnings, added some asserts, and compiling with gcc-4.5 and mingw-w64 #186

Closed
wants to merge 4 commits into from

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Sep 15, 2011

No description provided.

@bnoordhuis
Copy link
Contributor

Merged everything except 484d3ba. @piscisaureus: can you check that commit?

@piscisaureus
Copy link

@bnoordhuis can't do right now, I have only mingw32 and I'm afraid installing mingw-w64 will break that. Tomorrow I will get mingw-w64 on my office machine and try.

@nddrylliog
Copy link

@picsisaureus Sorry to disturb, but wouldn't it be a good idea to set up a 32-bit VM and a 64-bit VM ? I know it helps me a lot when developing. You can even install SSH servers on Windows (yeah, they exist) and set up port forwarding in VirtualBox or equivalent so that you can ssh into your virtual machines from anywhere, and automate the builds, it's damn convenient!

@piscisaureus
Copy link

@erickt
Replacing ws2_32.lib b y -lws2_32 doesn't fly. It breaks the msvc build. Are you sure this is necessary?

@luislavena
Copy link
Contributor

If I can chime in, I don't use gyp for MinGW, AFAIK, is not even supported at this time. I use the makefiles directly.

@erickt that is what you tried to solve?

@erickt
Copy link
Contributor Author

erickt commented Sep 16, 2011

I'm okay on punting on the mingw-w64 commit for now. I'll close.

@erickt erickt closed this Sep 16, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants