Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

fix up gyp #618

Closed
ry opened this Issue · 2 comments

2 participants

@ry
ry commented

direct_dependet_settings should be link_settings in a few places
https://gist.github.com/55f402136e3f6067707e

also removes "ldlags" ...

cc @tootallnate @bnoordhuis

@bnoordhuis bnoordhuis closed this issue from a commit
@bnoordhuis bnoordhuis build: use link_settings, fix typo
* Use link_settings instead of direct_dependent_settings.
* Fix typo: s/ldlags/ldflags/

Pointed out by a certain R.L. Dahl of San Francisco, CA.

Fixes #618.
deeec42
@bnoordhuis bnoordhuis closed this in deeec42
@bnoordhuis

I couldn't get the patch to merge but I landed a more or less verbatim copy with attribution in deeec42.

@ry
ry commented

thanks ben! sorry for the shitty patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.