build for android #661

Closed
dvv opened this Issue Dec 21, 2012 · 9 comments

Comments

Projects
None yet
4 participants
Contributor

dvv commented Dec 21, 2012

Hi!

Here is the patch to make libuv build under android-ndk (ver 14).
Please, consider applying.

TIA,
--Vladimir

Contributor

txdv commented Dec 21, 2012

I see no patch

Contributor

dvv commented Dec 21, 2012

"Here" is a link.

http://busybox.net/~dvv/uv-android.patch

The most irritating is that ares rely on arpa/nameser[_compat].h which are pruned from android-ndk.
An option would be to hold these somewhere under the uv tree

Contributor

saghul commented Dec 21, 2012

But ares is no longer part of libuv, so I guess that belongs to some new project, or a contribution to c-ares? IIRC ares master is supposed to build on Android.

Contributor

dvv commented Dec 21, 2012

what's ares master? this one? https://github.com/bagder/c-ares

Contributor

saghul commented Dec 21, 2012

Yes, that one. Go through the changelog and commits, I recall seeing some
Android related stuff there.

On Friday, December 21, 2012, Vladimir Dronnikov wrote:

what's ares master? this one? https://github.com/bagder/c-ares


Reply to this email directly or view it on GitHubhttps://github.com/joyent/libuv/issues/661#issuecomment-11612489.

/Saúl
http://saghul.net | http://sipdoc.net

Contributor

dvv commented Dec 21, 2012

oh, right.
but libuv now depends on advanced pthread stuff like pthread_condattr_setclock and it's certainly missing in android-ndk.
seems full stop here...

Contributor

txdv commented Dec 22, 2012

#ifdef PTHREAD ?
Just define all the thread stuff out

Contributor

dvv commented Dec 22, 2012

How so?

Contributor

bnoordhuis commented Dec 22, 2012

I can't take the patch, it needs to be against the current master. I think I'm open to patches that conditionally compile out the threading stuff but in the case of Android, I suggest you complain to upstream - there is no reason for GOOG to not add e.g. pthread_condattr_setclock(), the kernel supports it just fine.

@bnoordhuis bnoordhuis closed this Dec 22, 2012

@creationix creationix referenced this issue in luvit/luvit Dec 24, 2012

Closed

luvit for android patch #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment