Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

signals: uv.h comments out of date? #668

Closed
nikhilm opened this Issue Dec 25, 2012 · 1 comment

Comments

Projects
None yet
2 participants

nikhilm commented Dec 25, 2012

It seems signals support has progressed, but the comments in uv.h haven't been updated. Possible problem spots:

  • Comment before struct uv_signal_s - TODO about only default event loop supporting signals
  • Comment before uv_signal_init - Windows no-ops, but the windows functions seem to do something since commit c4dbb60, and the comments in uv_signal_s have been updated about it.
Contributor

bnoordhuis commented Dec 25, 2012

Fixed in 3164f1e, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment