unix, windows: close callbacks are run at separate stages #699

Closed
bnoordhuis opened this Issue Feb 5, 2013 · 1 comment

Comments

Projects
None yet
1 participant
Contributor

bnoordhuis commented Feb 5, 2013

Compare:

https://github.com/joyent/libuv/blob/8311390/src/unix/core.c#L288-298

With:

https://github.com/joyent/libuv/blob/8311390/src/win/core.c#L265-291

uv-win runs close callbacks before the poll, uv-unix runs them afterwards. Which one is correct?

/cc @piscisaureus

@bnoordhuis bnoordhuis referenced this issue in nodejs/node-v0.x-archive Feb 5, 2013

Closed

move setImmediate from timer to uv_check #3872

Contributor

bnoordhuis commented Feb 25, 2013

Discussed with @piscisaureus and decided it's not an issue. Close callbacks on Windows can take several ticks to complete anyway while they almost always complete on the next tick on Unices.

@bnoordhuis bnoordhuis closed this Feb 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment