Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

unix, windows: close callbacks are run at separate stages #699

Closed
bnoordhuis opened this Issue · 1 comment

1 participant

@bnoordhuis

Compare:

https://github.com/joyent/libuv/blob/8311390/src/unix/core.c#L288-298

With:

https://github.com/joyent/libuv/blob/8311390/src/win/core.c#L265-291

uv-win runs close callbacks before the poll, uv-unix runs them afterwards. Which one is correct?

/cc @piscisaureus

@bnoordhuis

Discussed with @piscisaureus and decided it's not an issue. Close callbacks on Windows can take several ticks to complete anyway while they almost always complete on the next tick on Unices.

@bnoordhuis bnoordhuis closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.