src/ and include/ directories #71

Closed
ry opened this Issue Jun 28, 2011 · 7 comments

Projects

None yet

2 participants

@ry
ry commented Jun 28, 2011

Please reorganize the project tree so that ares.h and uv.h are in include/ and the source files are in src/. Patch should fix build systems on all platforms.

@ry
ry commented Jun 28, 2011

wait until the multiplicity patch is landed.

@ry
ry commented Jul 6, 2011

not waiting for multiplicity.

@piscisaureus can you please review http://nodejs.org/0001-Fixes-71.-src-and-include-directories.patch

@ry ry closed this in a26f93d Jul 7, 2011
@piscisaureus piscisaureus reopened this Jul 7, 2011
@piscisaureus
Joyent member

Sorry - this is unreviewable. Can you explain to me what you have done?

@ry
ry commented Jul 7, 2011

i've moved the public headers into a directory include and source code into src and updated the config-unix.mk, config-mingw.mk, and Makefile

@piscisaureus
Joyent member

Okay lgtm.
I will make the necessary modifications to the msvc projects.

@ry ry added a commit that referenced this issue Jul 7, 2011
@ry ry src/ and include/ directories
Helps #71 but does not update the MSVC files.
ce8ff30
@ry
ry commented Jul 7, 2011

complete in 81bb15f

@ry ry closed this Jul 7, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment