Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

uv_run doesn't update the time for uv_now if there isn't anything to do in the loop #846

Closed
Matheus28 opened this Issue Jul 7, 2013 · 1 comment

Comments

Projects
None yet
1 participant

Title speaks for itself. In https://github.com/joyent/libuv/blob/master/src/win/core.c#L282 (uv_run), uv_update_time should also be called when the loop doesn't run so the time is always updated. So that line should be copied to the line just before the while loop.

Test case ("Finished\n" never prints):

printf("Started\n");
int64_t start = uv_now(loop);
while(uv_now(loop) - start < 1000){
    uv_run(loop, UV_RUN_NOWAIT);
}

printf("Finished\n");

@saghul saghul closed this in 15af49a Dec 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment