Skip to content
This repository has been archived by the owner on May 4, 2018. It is now read-only.

test, build: fix Android NDK r9c compatibility #1133

Closed
wants to merge 2 commits into from
Closed

test, build: fix Android NDK r9c compatibility #1133

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 21, 2014

r9c removed the toolchain currently used, and e403a2c introduced a test that fails when built against the NDK.

More info on both:
http://www.gnu.org/savannah-checkouts/gnu/libc/manual/html_node/Permission-Bits.html
http://developer.android.com/tools/sdk/ndk/index.html#Revisions

@Nodejs-Jenkins
Copy link

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit lgierth/libuv@070c9b1a73bb6a5a79ec3d36c0bac71cc1e39f4d has the following error(s):

  • First line of commit message must be no longer than 50 characters
  • Commit message must indicate the subsystem this commit changes
  • Commit message line too long: 3

Commit lgierth/libuv@63d559797aed8e4407f2a2166db1f2b19b8e67f8 has the following error(s):

  • Commit message must indicate the subsystem this commit changes

The following commiters were not found in the CLA:

  • Lars Gierth

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

@ghost
Copy link
Author

ghost commented Feb 21, 2014

I'm not sure about these failing tests, they don't seem related to my changes.

Lars Gierth added 2 commits February 21, 2014 05:48
S_IREAD and S_IWRITE are obsolete in GNU libs and
not included in the Android NDK's libc. See
http://www.gnu.org/savannah-checkouts/gnu/libc
/manual/html_node/Permission-Bits.html
@ghost
Copy link
Author

ghost commented Feb 21, 2014

I addressed Jenkins' comments

@saghul
Copy link
Contributor

saghul commented Feb 21, 2014

LGTM, have you signed the CLA?

@saghul
Copy link
Contributor

saghul commented Feb 21, 2014

Thanks @lgierth! Landed in 1ad6180 and cd67e10.

@saghul saghul closed this Feb 21, 2014
@ghost
Copy link
Author

ghost commented Feb 22, 2014

and e403a2c introduced a test that fails when built against the NDK.

That should actually say "fails to build against the NDK". A failing test is ok, but the latest v0.11.x doesn't even build against the NDK.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants