Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add interval and count to keep-alive #269

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants

We should be able to specify the probe interval and the failure count for keep-alive's on sockets.

Corresponding node pull request: joyent/node#2239

Member

piscisaureus commented Apr 4, 2012

We should be able to specify the probe interval and the failure count for keep-alive's on sockets.

Why is that needed?

It is needed because the default probe interval and failure counts set by the OS are too extreme and if you have an application that keeps a lot of sockets open (say a server that hosts a lot of clients over socket connections) you'd want to fine-tune the values to be very low.

Contributor

ibc commented May 23, 2012

I agree. Depending on OS default values is not (always) good.

txdv commented on aefb187 Sep 29, 2012

documenting that if count = 0 or interval = 0 that it won't change would be good imo

If I make a new pull request pointing at master and add the documentation for count/interval being 0, can it be merged?

Updated with Windows support for interval, documentation added that @txdv suggested and targeted master.
#729

@fastest963 fastest963 closed this Mar 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment