Skip to content

Implement uid/gid argument to uv_spawn #389

Closed
wants to merge 2 commits into from

3 participants

@isaacs
Joyent member
isaacs commented Apr 25, 2012

This is necessary to replace the uid/gid arguments to child_process.spawn in Node, which apparently started silently not working as of 0.6.

@tjfontaine

I believe uid_t is generally uint32 on linux, it may not be wise to use int to describe uid/gid

@piscisaureus
Joyent member

gid_t is a type, right?

@piscisaureus
Joyent member

als, this could be backported to 0.6 as uv_spawn2, similar to what we did for 64 bit file offsets.

@tjfontaine
@isaacs
Joyent member
isaacs commented Apr 25, 2012

Updated to use uid_t and gid_t. It's still using -1 as the sentinel value, so if you have a user with a uid of 0xffffffff or whatever, you won't be able to setuid to them, which seems rare and strange enough to not care about.

isaacs added some commits Apr 25, 2012
@isaacs isaacs Fix #388 Implement uid/gid argument to uv_spawn 47d5df5
@isaacs isaacs spawn: uid/gid Review updates 271b17c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.