Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

windows: fix uv_interface_addresses #643

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Member

piscisaureus commented Dec 3, 2012

@sblom or @bnoordhuis, please review

I also intend to land this in v0.8 to fix joyent/node#4353

piscisaureus added some commits Dec 3, 2012

@piscisaureus piscisaureus windows: add some error code mappings 0f0fee5
@piscisaureus piscisaureus windows: improve / fix uv_interface_addresses
* If GetAdaptersAddresses() failed, it would return UV_OK nonetheless,
  but the `adresses` and `count` out parameters would not be set.

* When adapters were enabled or added in between the two
  GetAdaptersAddresses() calls, it would fail.

* In case of an out of memory situation, libuv would crash with a fatal
  error.

* All interface information is now stored in a single heap-allocated
  area.
5471b9e

I'm surprised that !!(==) would produce a different result from plain ==

Member

piscisaureus replied Dec 4, 2012

You're right, I don't know what I was thinking.

sblom commented on 5471b9e Dec 4, 2012

lgtm

Contributor

bnoordhuis commented Dec 4, 2012

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment