Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fix Makefile build system for 'make test' to run ok on Linux. #644

Closed
wants to merge 1 commit into from

3 participants

@hnakamur

No description provided.

@shigeki

Duplicated in #632 . Need kvm link flags on *BSD but not sure on MacOS.
@bnoordhuis Any thoughts?

@bnoordhuis

So the reason I switched it to dynamic linking is that I want to iron out the bugs in the .so build. If you run into issues, please report them and I'll (help you) fix them.

@shigeki

@bnoordhuis I understand you need a check in a shared library. An link error of src/async.o as is shown in #632 . It occurs after make then make test where objects are not compiled with -fPIC.

@hnakamur

I close this pull request as this is duplicate of #632.
Please comment on #632 for further discussion.

@hnakamur hnakamur closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 1 deletion.
  1. +1 −1  Makefile
  2. +1 −0  config-unix.mk
View
2  Makefile
@@ -43,7 +43,7 @@ BENCHMARKS=test/blackhole-server.c test/echo-server.c test/dns-server.c test/ben
all: libuv.a
-test/run-tests$(E): test/run-tests.c test/runner.c $(RUNNER_SRC) $(TESTS) libuv.$(SOEXT)
+test/run-tests$(E): test/run-tests.c test/runner.c $(RUNNER_SRC) $(TESTS) libuv.a
$(CC) $(CPPFLAGS) $(RUNNER_CFLAGS) -o $@ $^ $(RUNNER_LIBS) $(RUNNER_LINKFLAGS)
test/run-benchmarks$(E): test/run-benchmarks.c test/runner.c $(RUNNER_SRC) $(BENCHMARKS) libuv.$(SOEXT)
View
1  config-unix.mk
@@ -81,6 +81,7 @@ ifeq (Linux,$(uname_S))
CSTDFLAG += -D_GNU_SOURCE
LINKFLAGS+=-ldl -lrt
RUNNER_CFLAGS += -D_GNU_SOURCE
+RUNNER_LINKFLAGS += -ldl -lrt
OBJS += src/unix/linux/linux-core.o \
src/unix/linux/inotify.o \
src/unix/linux/syscalls.o
Something went wrong with that request. Please try again.