Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Solaris directory watching resource leak / segfault bug fix #654

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

ashaffer commented Dec 13, 2012

Libuv doesn't properly clean up directory watches on solaris if they are in the PORT_LOADED state. I encountered this problem in node.js. To reproduce it, execute the following in a node console on solaris:

fs = require('fs');
h = fs.watch(<directory>);
h.close();

Then in a separate shell (without closing the node shell, of course) touch the folder you watched and you should get a seg fault.

Contributor

bnoordhuis commented Dec 13, 2012

The change itself LGTM but would it be possible to add a regression test?

Contributor

ashaffer commented Dec 13, 2012

Added.

Contributor

bnoordhuis commented Dec 14, 2012

Thanks. Can you sign the CLA? I believe you're not on the list yet.

Contributor

ashaffer commented Dec 14, 2012

Ok, signed.

Contributor

bnoordhuis commented Dec 14, 2012

Thanks Andrew, landed in 4997738. It'll be part of the next v0.8 node release.

@bnoordhuis bnoordhuis closed this Dec 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment