Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

build libuv.a and libuv.so in different directories fix #659 #660

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

vtudose commented Dec 18, 2012

No description provided.

Contributor

bnoordhuis commented Dec 19, 2012

Build output should go in out/ (build/ is used by gyp) but apart from that LGTM, thanks! Vlad, can you sign the CLA?

vtudose commented Dec 19, 2012

I've signed the CLA.
I changed the folder to out/
I also modified the targets to take into account the .h files

Contributor

shigeki commented Dec 19, 2012

@vtudose Awesome! #632 is also resolved. I've never think of MAKECMDGOALS . Thanks.

Contributor

bnoordhuis commented Dec 19, 2012

Thanks Vlad, landed in 4b115f8.

@bnoordhuis bnoordhuis closed this Dec 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment