GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
This still needs Windows version.
Style: two newlines between functions and headers / declarations.
Style: split the declaration and the assignment.
In general, single line if statements don't have braces, i.e.:
if (r == -1)
Use uv_strlcpy() here.
Can you add some short comments describing what the function does and what inputs it takes / outputs it produces?
@bnoordhuis all fixed.
unix: add os information
LGTM but it needs Windows stubs (bonus points for working implementations). I suggest that you copy out an empty string besides returning UV_ENOSYS.
@mmalecki Are you still planning on finishing this? It'll need some rebasing to apply to master.
No followup, closing.