Windows build: support vs2012, fix shared #677

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@gigi81
Contributor

gigi81 commented Jan 5, 2013

Added support for Visual Studio 2012(updated gyp to the latest available
version)
Fixed shared build on windows (run-tests was failing)

Windows build: support vs2012, fix shared
Added support for Visual Studio 2012(updated gyp to the latest available
version)
Fixed shared build on windows (run-tests was failing)

@gigi81 gigi81 referenced this pull request in txdv/LibuvSharp Jan 5, 2013

Open

What is the status of LibuvSharp? #2

@@ -353,6 +353,51 @@
'_XOPEN_SOURCE=500',
],
}],
+ ['OS=="win" and library=="shared_library"', {

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Jan 5, 2013

Contributor

Why is this section necessary?

@bnoordhuis

bnoordhuis Jan 5, 2013

Contributor

Why is this section necessary?

This comment has been minimized.

Show comment Hide comment
@gigi81

gigi81 Jan 6, 2013

Contributor

Without that section when building the shared(dll) version of the library you get this error:

test-spawn.obj : error LNK2019: unresolved external symbol _uv_utf8_to_utf16 referenced in function _run_test_environment_creation [C:\Users\Luigi\Documents\GitHub\libuv\run-tests.vcxproj]
test-spawn.obj : error LNK2019: unresolved external symbol _make_program_args referenced in function _run_test_argument_escaping [C:\Users\Luigi\Documents\GitHub\libuv\run-tests.vcxproj]
test-spawn.obj : error LNK2019: unresolved external symbol _quote_cmd_arg referenced in function _run_test_argument_escaping [C:\Users\Luigi\Documents\GitHub\libuv\run-tests.vcxproj]
test-spawn.obj : error LNK2019: unresolved external symbol _make_program_env referenced in function _run_test_environment_creation [C:\Users\Luigi\Documents\GitHub\libuv\run-tests.vcxproj]

@gigi81

gigi81 Jan 6, 2013

Contributor

Without that section when building the shared(dll) version of the library you get this error:

test-spawn.obj : error LNK2019: unresolved external symbol _uv_utf8_to_utf16 referenced in function _run_test_environment_creation [C:\Users\Luigi\Documents\GitHub\libuv\run-tests.vcxproj]
test-spawn.obj : error LNK2019: unresolved external symbol _make_program_args referenced in function _run_test_argument_escaping [C:\Users\Luigi\Documents\GitHub\libuv\run-tests.vcxproj]
test-spawn.obj : error LNK2019: unresolved external symbol _quote_cmd_arg referenced in function _run_test_argument_escaping [C:\Users\Luigi\Documents\GitHub\libuv\run-tests.vcxproj]
test-spawn.obj : error LNK2019: unresolved external symbol _make_program_env referenced in function _run_test_environment_creation [C:\Users\Luigi\Documents\GitHub\libuv\run-tests.vcxproj]

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Jan 6, 2013

Contributor

Isn't that a matter of fixing the sources list in the normal OS=="win" section? This seems like a rather massive duplication.

@bnoordhuis

bnoordhuis Jan 6, 2013

Contributor

Isn't that a matter of fixing the sources list in the normal OS=="win" section? This seems like a rather massive duplication.

This comment has been minimized.

Show comment Hide comment
@gigi81

gigi81 Jan 6, 2013

Contributor

It's the cleanest solution I can think of.
This section is only needed when building the dll on windows. Other solution would involve to change multiple sections that don't actually need this change. The change is a single block (that can be easily removed if the future if not needed anymore) so I think it's really clean.
As long as the test program is using library staff that is not exported by the library (because not needed) this change is required to make the build work.

@gigi81

gigi81 Jan 6, 2013

Contributor

It's the cleanest solution I can think of.
This section is only needed when building the dll on windows. Other solution would involve to change multiple sections that don't actually need this change. The change is a single block (that can be easily removed if the future if not needed anymore) so I think it's really clean.
As long as the test program is using library staff that is not exported by the library (because not needed) this change is required to make the build work.

@gigi81

This comment has been minimized.

Show comment Hide comment
@gigi81

gigi81 Jan 23, 2013

Contributor

@bnoordhuis any update? planning to merge this? at lest merge the bat file. even if the dll build will be left broken at least we have a build on vs2012

Contributor

gigi81 commented Jan 23, 2013

@bnoordhuis any update? planning to merge this? at lest merge the bat file. even if the dll build will be left broken at least we have a build on vs2012

@bnoordhuis

This comment has been minimized.

Show comment Hide comment
@bnoordhuis

bnoordhuis Jan 23, 2013

Contributor

@piscisaureus should review it (he works on the Windows side the most) but he's rather busy.

Contributor

bnoordhuis commented Jan 23, 2013

@piscisaureus should review it (he works on the Windows side the most) but he's rather busy.

@saghul

This comment has been minimized.

Show comment Hide comment
@saghul

saghul Sep 23, 2013

Contributor

VS2012 support already landed long ago, please one a new pull request if there is anything else to be fixed there, thanks!

Contributor

saghul commented Sep 23, 2013

VS2012 support already landed long ago, please one a new pull request if there is anything else to be fixed there, thanks!

@saghul saghul closed this Sep 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment