MANTA-5334 timer for MANTA-5332 could be improved for max objects and multiple shards #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
papertigers
reviewed
Jul 2, 2020
manager/src/jobs/evacuate.rs
Outdated
Comment on lines
2129
to
2136
| if let Some(st) = *start_time { | ||
| info!( | ||
| "Evacuate Job object movement time: {} seconds", | ||
| st.elapsed().as_secs() | ||
| ); | ||
| } | ||
|
|
||
| *start_time = None; |
There was a problem hiding this comment.
2130 if let Some(st) = start_time.take() {
2131 info!(
2132 "Evacuate Job object movement time: {} seconds",
2133 st.elapsed().as_secs()
2134 );
2135 }I think something like this would be cleaner and allows you to ditch the *start_time = None bit.
|
👍 I pulled the code and looked through it... this change makes sense. I also looked into |
papertigers
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.