Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkgin up gets executed in the global zone and not inside the build zone #7

Closed

Conversation

@MerlinDMC
Copy link
Contributor

@MerlinDMC MerlinDMC commented Sep 4, 2014

The semicolon ends the zlogin call and pkgin is executed in the global zone instead.

Quoting the complete command string will execute pkgin up inside the build zone.

The semicolon ends the zlogin call and pkgin is executed in the global zone instead.
@dcrudgington
Copy link
Contributor

@dcrudgington dcrudgington commented Sep 5, 2014

Fixed, thanks.

@MerlinDMC MerlinDMC deleted the fixes/pkgin-exec-in-global-zone branch Sep 6, 2014
@CyBeRoni
Copy link

@CyBeRoni CyBeRoni commented Nov 22, 2015

Did you fix this and actually push it? https://github.com/joyent/mibe/blob/master/lib/mibe.inc#L340 appears unmodified still.

@MerlinDMC
Copy link
Contributor Author

@MerlinDMC MerlinDMC commented Nov 22, 2015

@CyBeRoni I did push the fix to my branch - yes

The currently available mibe here in this repository is probably very outdated from what is actually used.
I did ask for an update but that seems to have a) not priority and b) licensing issues :(

Feel free to use my fork http://github.com/MerlinDMC/mibe

@CyBeRoni
Copy link

@CyBeRoni CyBeRoni commented Nov 22, 2015

Yeah but everyone gets pointed at this repo so it'd be nice if such community fixes appeared here too rather than only in Joyent's private version of the same.

An update would be nice but as it is this code does what it needs to at least.

@chorrell
Copy link
Contributor

@chorrell chorrell commented Nov 22, 2015

The changes should be live now

@CyBeRoni
Copy link

@CyBeRoni CyBeRoni commented Nov 22, 2015

@chorrell -- You re-added the readme (which of course is good) but the problem referred to in this issue still exists :) Btw the license file was removed at some point too (in 7b302c0). Though it being on github does imply some manner of open-sourceness, it would be nice if it was re-added too.

@MerlinDMC
Copy link
Contributor Author

@MerlinDMC MerlinDMC commented Nov 22, 2015

The file looks like it's patched in the master branch. So this particular problem should be solved.

mibe/lib/mibe.inc

Lines 403 to 405 in a6468c0

mi_bzone_result=$(zlogin ${mi_bzone} 'PATH=/opt/local/bin:/opt/local/sbin:/usr/bin:/usr/sbin \
touch /opt/local/.dlj_license_accepted; pkgin -f -y up 2>&1' >> ${mi_bzone_logall} \
| tee -a ${mi_bzone_logall} >> ${mi_bzone_logerr} || echo $?);

Has nice quotes around the pkgin command.

@chorrell
Copy link
Contributor

@chorrell chorrell commented Nov 22, 2015

Yep.

And I just added and license. We typically use MPL2.

@CyBeRoni
Copy link

@CyBeRoni CyBeRoni commented Nov 22, 2015

Oh indeed, I just looked at the commits and didn't see one touching that file. Sorry for that.

Which is because you pushed a bunch of older commits and one made a few minutes ago. Gotcha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants