New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add barrier.abort (issue #8) #15

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@fkuo

fkuo commented Jan 29, 2014

No description provided.

@davepacheco

This comment has been minimized.

Member

davepacheco commented Feb 4, 2014

Thanks for doing this! Can you add some tests, an example, and update README.md? My main question is what the expected behavior is when you start an operation on a barrier that's aborted? The example would help clarify that.

Also, is "drain" the right event for conveying the error?

CC'ing @jclulow, since he's interested in this.

@jclulow

This comment has been minimized.

Member

jclulow commented Feb 4, 2014

If there's a different event for conveying errors, e.g. "error", then it would be good to ensure that "drain" does not ever fire in the error case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment