Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Pause process.stdin in stdin getter

Otherwise, it'll be ref'ed, and keep the process hanging.
  • Loading branch information...
commit 27d8b059fa214c56de6dc359ebdb8c05ad6b9f99 1 parent 5e3ca98
@isaacs isaacs authored
Showing with 35 additions and 0 deletions.
  1. +4 −0 src/node.js
  2. +31 −0 test/simple/test-stdin-hang.js
View
4 src/node.js
@@ -324,6 +324,10 @@
// For supporting legacy API we put the FD here.
stdin.fd = fd;
+ // stdin starts out life in a paused state, but node doesn't
+ // know yet. Call pause() explicitly to unref() it.
+ stdin.pause();
+
return stdin;
});
View
31 test/simple/test-stdin-hang.js
@@ -0,0 +1,31 @@
+// Copyright Joyent, Inc. and other Node contributors.
+//
+// Permission is hereby granted, free of charge, to any person obtaining a
+// copy of this software and associated documentation files (the
+// "Software"), to deal in the Software without restriction, including
+// without limitation the rights to use, copy, modify, merge, publish,
+// distribute, sublicense, and/or sell copies of the Software, and to permit
+// persons to whom the Software is furnished to do so, subject to the
+// following conditions:
+//
+// The above copyright notice and this permission notice shall be included
+// in all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+// USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+var common = require('../common');
+
+// This test *only* verifies that invoking the stdin getter does not
+// cause node to hang indefinitely.
+// If it does, then the test-runner will nuke it.
+
+// invoke the getter.
+process.stdin;
+
+console.error('Should exit normally now.');
Please sign in to comment.
Something went wrong with that request. Please try again.