Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

test: set rejectUnauthorized in tls/https tests

Update the tls and https tests to explicitly set rejectUnauthorized instead of
relying on the NODE_TLS_REJECT_UNAUTHORIZED environment variable getting set.
  • Loading branch information...
commit 3806cf0d640da3024d50208452d2dd9e3cb015d2 1 parent 35607f3
@bnoordhuis bnoordhuis authored
Showing with 183 additions and 164 deletions.
  1. +2 −4 test/fixtures/GH-892-request.js
  2. +4 −4 test/pummel/test-https-large-response.js
  3. +4 −4 test/pummel/test-tls-throttle.js
  4. +55 −25 test/simple/test-http-host-headers.js
  5. +1 −3 test/simple/test-http-url.parse-https.request.js
  6. +5 −7 test/simple/test-https-agent.js
  7. +2 −4 test/simple/test-https-drain.js
  8. +4 −7 test/simple/test-https-eof-for-eom.js
  9. +5 −5 test/simple/test-https-localaddress.js
  10. +3 −5 test/simple/test-https-pfx.js
  11. +8 −8 test/simple/test-https-socket-options.js
  12. +2 −4 test/simple/test-https-timeout.js
  13. +2 −4 test/simple/test-regress-GH-1531.js
  14. +10 −5 test/simple/test-tls-client-resume.js
  15. +2 −4 test/simple/test-tls-client-verify.js
  16. +8 −5 test/simple/test-tls-connect-given-socket.js
  17. +2 −1  test/simple/test-tls-connect-pipe.js
  18. +8 −5 test/simple/test-tls-connect-simple.js
  19. +5 −4 test/simple/test-tls-getcipher.js
  20. +4 −4 test/simple/test-tls-honorcipherorder.js
  21. +6 −6 test/simple/test-tls-npn-server-client.js
  22. +2 −7 test/simple/test-tls-over-http-tunnel.js
  23. +4 −5 test/simple/test-tls-passphrase.js
  24. +4 −4 test/simple/test-tls-pause-close.js
  25. +4 −4 test/simple/test-tls-pause.js
  26. +4 −4 test/simple/test-tls-peer-certificate-multi-keys.js
  27. +4 −4 test/simple/test-tls-peer-certificate.js
  28. +5 −4 test/simple/test-tls-remote.js
  29. +4 −4 test/simple/test-tls-request-timeout.js
  30. +4 −4 test/simple/test-tls-set-encoding.js
  31. +6 −6 test/simple/test-tls-sni-server-client.js
View
6 test/fixtures/GH-892-request.js
@@ -21,9 +21,6 @@
// Called by test/pummel/test-regress-GH-892.js
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var https = require('https');
var fs = require('fs');
var assert = require('assert');
@@ -35,7 +32,8 @@ var gotResponse = false;
var options = {
method: 'POST',
- port: PORT
+ port: PORT,
+ rejectUnauthorized: false
};
var req = https.request(options, function(res) {
View
8 test/pummel/test-https-large-response.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
@@ -53,7 +50,10 @@ var count = 0;
var gotResEnd = false;
server.listen(common.PORT, function() {
- https.get({ port: common.PORT }, function(res) {
+ https.get({
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function(res) {
console.log('response!');
res.on('data', function(d) {
View
8 test/pummel/test-tls-throttle.js
@@ -22,9 +22,6 @@
// Server sends a large string. Client counts bytes and pauses every few
// seconds. Makes sure that pause and resume work properly.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -56,7 +53,10 @@ var server = tls.Server(options, function(socket) {
var recvCount = 0;
server.listen(common.PORT, function() {
- var client = tls.connect(common.PORT);
+ var client = tls.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ });
client.on('data', function(d) {
process.stdout.write('.');
View
80 test/simple/test-http-host-headers.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var http = require('http'),
https = require('https'),
fs = require('fs'),
@@ -74,35 +71,50 @@ function testHttp() {
if (er) throw er;
- http.get({ method: 'GET',
+ http.get({
+ method: 'GET',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
- port: common.PORT }, cb).on('error', thrower);
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower);
- http.request({ method: 'GET',
+ http.request({
+ method: 'GET',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
- port: common.PORT }, cb).on('error', thrower).end();
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower).end();
- http.request({ method: 'POST',
+ http.request({
+ method: 'POST',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
- port: common.PORT }, cb).on('error', thrower).end();
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower).end();
- http.request({ method: 'PUT',
+ http.request({
+ method: 'PUT',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
- port: common.PORT }, cb).on('error', thrower).end();
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower).end();
- http.request({ method: 'DELETE',
+ http.request({
+ method: 'DELETE',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
- port: common.PORT }, cb).on('error', thrower).end();
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower).end();
});
}
@@ -124,40 +136,58 @@ function testHttps() {
httpsServer.listen(common.PORT, function(er) {
if (er) throw er;
- https.get({ method: 'GET',
+ https.get({
+ method: 'GET',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
- port: common.PORT }, cb).on('error', thrower);
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower);
- https.request({ method: 'GET',
+ https.request({
+ method: 'GET',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
- port: common.PORT }, cb).on('error', thrower).end();
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower).end();
- https.request({ method: 'POST',
+ https.request({
+ method: 'POST',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
- port: common.PORT }, cb).on('error', thrower).end();
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower).end();
- https.request({ method: 'PUT',
+ https.request({
+ method: 'PUT',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
- port: common.PORT }, cb).on('error', thrower).end();
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower).end();
- https.request({ method: 'DELETE',
+ https.request({
+ method: 'DELETE',
path: '/' + (counter++),
host: 'localhost',
//agent: false,
- port: common.PORT }, cb).on('error', thrower).end();
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower).end();
- https.get({ method: 'GET',
+ https.get({
+ method: 'GET',
path: '/setHostFalse' + (counter++),
host: 'localhost',
setHost: false,
- port: common.PORT }, cb).on('error', thrower).end();
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, cb).on('error', thrower).end();
});
}
View
4 test/simple/test-http-url.parse-https.request.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var https = require('https');
@@ -36,6 +33,7 @@ var httpsOptions = {
};
var testURL = url.parse('https://localhost:' + common.PORT);
+testURL.rejectUnauthorized = false;
function check(request) {
// assert that I'm https
View
12 test/simple/test-https-agent.js
@@ -19,17 +19,11 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-
-
if (!process.versions.openssl) {
console.error('Skipping because node compiled without OpenSSL.');
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var https = require('https');
@@ -55,7 +49,11 @@ server.listen(common.PORT, function() {
for (var i = 0; i < N; i++) {
setTimeout(function() {
for (var j = 0; j < M; j++) {
- https.get({ port: common.PORT, path: '/' }, function(res) {
+ https.get({
+ path: '/',
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function(res) {
console.log(res.statusCode);
if (++responses == N * M) server.close();
}).on('error', function(e) {
View
6 test/simple/test-https-drain.js
@@ -24,9 +24,6 @@ if (!process.versions.openssl) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var https = require('https');
@@ -50,8 +47,9 @@ var server = https.createServer(options, function(req, res) {
server.listen(common.PORT, function() {
var resumed = false;
var req = https.request({
+ method: 'POST',
port: common.PORT,
- method: 'POST'
+ rejectUnauthorized: false
}, function(res) {
var timer;
res.pause();
View
11 test/simple/test-https-eof-for-eom.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-
-
// I hate HTTP. One way of terminating an HTTP response is to not send
// a content-length header, not send a transfer-encoding: chunked header,
// and simply terminate the TCP connection. That is identity
@@ -34,9 +31,6 @@ if (!process.versions.openssl) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -77,7 +71,10 @@ var bodyBuffer = '';
server.listen(common.PORT, function() {
console.log('1) Making Request');
- var req = https.get({ port: common.PORT }, function(res) {
+ var req = https.get({
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function(res) {
server.close();
console.log('3) Client got response headers.');
View
10 test/simple/test-https-localaddress.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var https = require('https'),
fs = require('fs'),
@@ -48,11 +45,14 @@ var server = https.createServer(options, function (req, res) {
});
server.listen(common.PORT, "127.0.0.1", function() {
- var options = { host: 'localhost',
+ var options = {
+ host: 'localhost',
port: common.PORT,
path: '/',
method: 'GET',
- localAddress: '127.0.0.2' };
+ localAddress: '127.0.0.2',
+ rejectUnauthorized: false
+ };
var req = https.request(options, function(res) {
res.on('end', function() {
View
8 test/simple/test-https-pfx.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var https = require('https');
@@ -35,12 +32,13 @@ var options = {
path: '/',
pfx: pfx,
passphrase: 'sample',
- requestCert: true
+ requestCert: true,
+ rejectUnauthorized: false
};
var server = https.createServer(options, function(req, res) {
assert.equal(req.socket.authorized, false); // not a client cert
- assert.equal(req.socket.authorizationError, 'UNABLE_TO_GET_ISSUER_CERT');
+ assert.equal(req.socket.authorizationError, 'DEPTH_ZERO_SELF_SIGNED_CERT');
res.writeHead(200);
res.end('OK');
});
View
16 test/simple/test-https-socket-options.js
@@ -19,17 +19,11 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-
-
if (!process.versions.openssl) {
console.error('Skipping because node compiled without OpenSSL.');
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
@@ -56,7 +50,10 @@ var server_http = http.createServer(function(req, res) {
server_http.listen(common.PORT, function() {
- var req = http.request({ port: common.PORT }, function(res) {
+ var req = http.request({
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function(res) {
server_http.close();
});
// These methods should exist on the request and get passed down to the socket
@@ -75,7 +72,10 @@ var server_https = https.createServer(options, function(req, res) {
});
server_https.listen(common.PORT+1, function() {
- var req = https.request({ port: common.PORT+1 }, function(res) {
+ var req = https.request({
+ port: common.PORT + 1,
+ rejectUnauthorized: false
+ }, function(res) {
server_https.close();
});
// These methods should exist on the request and get passed down to the socket
View
6 test/simple/test-https-timeout.js
@@ -24,9 +24,6 @@ if (!process.versions.openssl) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var fs = require('fs');
@@ -46,7 +43,8 @@ var server = https.createServer(options, function() {
host: 'localhost',
port: common.PORT,
path: '/',
- method: 'GET'
+ method: 'GET',
+ rejectUnauthorized: false
});
req.setTimeout(10);
req.end();
View
6 test/simple/test-regress-GH-1531.js
@@ -27,9 +27,6 @@ if (!process.versions.openssl) {
var https = require('https');
var assert = require('assert');
var fs = require('fs');
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var options = {
@@ -46,9 +43,10 @@ var server = https.createServer(options, function(req, res) {
server.listen(common.PORT, function() {
https.get({
+ agent: false,
path: '/',
port: common.PORT,
- agent: false
+ rejectUnauthorized: false
}, function(res) {
console.error(res.statusCode);
gotCallback = true;
View
15 test/simple/test-tls-client-resume.js
@@ -28,9 +28,6 @@ if (!process.versions.openssl) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -53,7 +50,10 @@ var server = tls.Server(options, function(socket) {
server.listen(common.PORT, function() {
var session1 = null;
- var client1 = tls.connect({port: common.PORT}, function() {
+ var client1 = tls.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function() {
console.log('connect1');
assert.ok(!client1.isSessionReused(), 'Session *should not* be reused.');
session1 = client1.getSession();
@@ -62,7 +62,12 @@ server.listen(common.PORT, function() {
client1.on('close', function() {
console.log('close1');
- var opts = { 'session': session1, port: common.PORT };
+ var opts = {
+ port: common.PORT,
+ rejectUnauthorized: false,
+ session: session1
+ };
+
var client2 = tls.connect(opts, function() {
console.log('connect2');
assert.ok(client2.isSessionReused(), 'Session *should* be reused.');
View
6 test/simple/test-tls-client-verify.js
@@ -59,9 +59,6 @@ var testCases =
];
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var fs = require('fs');
@@ -137,7 +134,8 @@ function runTest(testIndex) {
port: common.PORT,
ca: tcase.ca.map(loadPEM),
key: loadPEM(tcase.key),
- cert: loadPEM(tcase.cert)
+ cert: loadPEM(tcase.cert),
+ rejectUnauthorized: false
};
View
13 test/simple/test-tls-connect-given-socket.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -41,8 +38,14 @@ var server = tls.createServer(options, function(socket) {
serverConnected = true;
socket.end('Hello');
}).listen(common.PORT, function() {
- var socket = net.connect(common.PORT, function() {
- var client = tls.connect({socket: socket}, function() {
+ var socket = net.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function() {
+ var client = tls.connect({
+ rejectUnauthorized: false,
+ socket: socket
+ }, function() {
clientConnected = true;
var data = '';
client.on('data', function(chunk) {
View
3  test/simple/test-tls-connect-pipe.js
@@ -37,7 +37,8 @@ var server = tls.Server(options, function(socket) {
server.close();
});
server.listen(common.PIPE, function() {
- var client = tls.connect(common.PIPE, function() {
+ var options = { rejectUnauthorized: false };
+ var client = tls.connect(common.PIPE, options, function() {
++clientConnected;
client.end();
});
View
13 test/simple/test-tls-connect-simple.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -42,12 +39,18 @@ var server = tls.Server(options, function(socket) {
});
server.listen(common.PORT, function() {
- var client1 = tls.connect({port: common.PORT}, function() {
+ var client1 = tls.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function() {
++clientConnected;
client1.end();
});
- var client2 = tls.connect({port: common.PORT});
+ var client2 = tls.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ });
client2.on('secureConnect', function() {
++clientConnected;
client2.end();
View
9 test/simple/test-tls-getcipher.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -46,7 +43,11 @@ var server = tls.createServer(options, function(cleartextStream) {
});
server.listen(common.PORT, '127.0.0.1', function() {
- var client = tls.connect(common.PORT, '127.0.0.1', function() {
+ var client = tls.connect({
+ host: '127.0.0.1',
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function() {
var cipher = client.getCipher();
assert.equal(cipher.name, cipher_list[0]);
assert(cipher_version_pattern.test(cipher.version));
View
8 test/simple/test-tls-honorcipherorder.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -49,7 +46,10 @@ function test(honorCipherOrder, clientCipher, expectedCipher, cb) {
nconns++;
});
server.listen(common.PORT, localhost, function() {
- var coptions = {secureProtocol: SSL_Method};
+ var coptions = {
+ rejectUnauthorized: false,
+ secureProtocol: SSL_Method
+ };
if (clientCipher) {
coptions.ciphers = clientCipher;
}
View
12 test/simple/test-tls-npn-server-client.js
@@ -25,9 +25,6 @@ if (!process.features.tls_npn) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common'),
assert = require('assert'),
fs = require('fs'),
@@ -55,19 +52,22 @@ var clientsOptions = [{
key: serverOptions.key,
cert: serverOptions.cert,
crl: serverOptions.crl,
- NPNProtocols: ['a', 'b', 'c']
+ NPNProtocols: ['a', 'b', 'c'],
+ rejectUnauthorized: false
},{
port: serverPort,
key: serverOptions.key,
cert: serverOptions.cert,
crl: serverOptions.crl,
- NPNProtocols: ['c', 'b', 'e']
+ NPNProtocols: ['c', 'b', 'e'],
+ rejectUnauthorized: false
},{
port: serverPort,
key: serverOptions.key,
cert: serverOptions.cert,
crl: serverOptions.crl,
- NPNProtocols: ['first-priority-unsupported', 'x', 'y']
+ NPNProtocols: ['first-priority-unsupported', 'x', 'y'],
+ rejectUnauthorized: false
}];
var serverResults = [],
View
9 test/simple/test-tls-over-http-tunnel.js
@@ -19,17 +19,11 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-
-
if (!process.versions.openssl) {
console.error('Skipping because node compiled without OpenSSL.');
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
@@ -153,7 +147,8 @@ proxy.listen(proxyPort, function() {
key: key,
cert: cert,
socket: socket, // reuse the socket
- agent: false
+ agent: false,
+ rejectUnauthorized: false
}, function(res) {
assert.equal(200, res.statusCode);
View
9 test/simple/test-tls-passphrase.js
@@ -24,9 +24,6 @@ if (!process.versions.openssl) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -53,7 +50,8 @@ server.listen(common.PORT, function() {
port: common.PORT,
key: key,
passphrase: 'passphrase',
- cert: cert
+ cert: cert,
+ rejectUnauthorized: false
}, function() {
++connectCount;
});
@@ -67,7 +65,8 @@ assert.throws(function() {
port: common.PORT,
key: key,
passphrase: 'invalid',
- cert: cert
+ cert: cert,
+ rejectUnauthorized: false
});
});
View
8 test/simple/test-tls-pause-close.js
@@ -24,9 +24,6 @@ if (!process.versions.openssl) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -69,7 +66,10 @@ var server = tls.createServer(options, function(s) {
});
server.listen(common.PORT, function() {
- var c = tls.connect({port: common.PORT}, function() {
+ var c = tls.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function() {
console.log('client connected');
c.socket.on('end', function() {
console.log('client socket ended');
View
8 test/simple/test-tls-pause.js
@@ -24,9 +24,6 @@ if (!process.versions.openssl) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -48,7 +45,10 @@ var server = tls.Server(options, function(socket) {
server.listen(common.PORT, function() {
var resumed = false;
- var client = tls.connect({port: common.PORT}, function() {
+ var client = tls.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function() {
client.pause();
common.debug('paused');
send();
View
8 test/simple/test-tls-peer-certificate-multi-keys.js
@@ -24,9 +24,6 @@ if (!process.versions.openssl) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -45,7 +42,10 @@ var server = tls.createServer(options, function(cleartext) {
cleartext.end('World');
});
server.listen(common.PORT, function() {
- var socket = tls.connect({port: common.PORT}, function() {
+ var socket = tls.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function() {
var peerCert = socket.getPeerCertificate();
common.debug(util.inspect(peerCert));
assert.deepEqual(peerCert.subject.OU,
View
8 test/simple/test-tls-peer-certificate.js
@@ -24,9 +24,6 @@ if (!process.versions.openssl) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -45,7 +42,10 @@ var server = tls.createServer(options, function(cleartext) {
cleartext.end('World');
});
server.listen(common.PORT, function() {
- var socket = tls.connect({port: common.PORT}, function() {
+ var socket = tls.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function() {
var peerCert = socket.getPeerCertificate();
common.debug(util.inspect(peerCert));
assert.equal(peerCert.subject.subjectAltName,
View
9 test/simple/test-tls-remote.js
@@ -24,9 +24,6 @@ if (!process.versions.openssl) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -51,7 +48,11 @@ server.listen(common.PORT, '127.0.0.1', function() {
assert.equal(server.address().address, '127.0.0.1');
assert.equal(server.address().port, common.PORT);
- var c = tls.connect({port: common.PORT, host: '127.0.0.1'}, function() {
+ var c = tls.connect({
+ host: '127.0.0.1',
+ port: common.PORT,
+ rejectUnauthorized: false
+ }, function() {
assert.equal(c.address().address, c.socket.address().address);
assert.equal(c.address().port, c.socket.address().port);
View
8 test/simple/test-tls-request-timeout.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -45,7 +42,10 @@ var server = tls.Server(options, function(socket) {
});
server.listen(common.PORT, function() {
- var socket = tls.connect({port: common.PORT});
+ var socket = tls.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ });
});
process.on('exit', function() {
View
8 test/simple/test-tls-set-encoding.js
@@ -19,9 +19,6 @@
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common');
var assert = require('assert');
var tls = require('tls');
@@ -44,7 +41,10 @@ var server = tls.Server(options, function(socket) {
server.listen(common.PORT, function() {
- var client = tls.connect({port: common.PORT});
+ var client = tls.connect({
+ port: common.PORT,
+ rejectUnauthorized: false
+ });
var buffer = '';
View
12 test/simple/test-tls-sni-server-client.js
@@ -28,9 +28,6 @@ if (!process.features.tls_sni) {
process.exit(0);
}
-// disable strict server certificate validation by the client
-process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0';
-
var common = require('../common'),
assert = require('assert'),
fs = require('fs'),
@@ -67,19 +64,22 @@ var clientsOptions = [{
key: loadPEM('agent1-key'),
cert: loadPEM('agent1-cert'),
ca: [loadPEM('ca1-cert')],
- servername: 'a.example.com'
+ servername: 'a.example.com',
+ rejectUnauthorized: false
},{
port: serverPort,
key: loadPEM('agent2-key'),
cert: loadPEM('agent2-cert'),
ca: [loadPEM('ca2-cert')],
- servername: 'b.test.com'
+ servername: 'b.test.com',
+ rejectUnauthorized: false
},{
port: serverPort,
key: loadPEM('agent3-key'),
cert: loadPEM('agent3-cert'),
ca: [loadPEM('ca1-cert')],
- servername: 'c.wrong.com'
+ servername: 'c.wrong.com',
+ rejectUnauthorized: false
}];
var serverResults = [],
Please sign in to comment.
Something went wrong with that request. Please try again.