Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

module: fix pointer reference to out-of-scope variable

Reported by Tom Hughes.
  • Loading branch information...
commit 5e37e10e41c269b12ede9126126032e3a1c57973 1 parent e8d268f
@bnoordhuis bnoordhuis authored
Showing with 5 additions and 1 deletion.
  1. +5 −1 src/node.cc
View
6 src/node.cc
@@ -1574,6 +1574,7 @@ typedef void (*extInit)(Handle<Object> exports);
// DLOpen is node.dlopen(). Used to load 'module.node' dynamically shared
// objects.
Handle<Value> DLOpen(const v8::Arguments& args) {
+ node_module_struct compat_mod;
HandleScope scope;
if (args.Length() < 2) return Undefined();
@@ -1616,10 +1617,13 @@ Handle<Value> DLOpen(const v8::Arguments& args) {
// Get the init() function from the dynamically shared object.
node_module_struct *mod = static_cast<node_module_struct *>(dlsym(handle, symstr));
free(symstr);
+ symstr = NULL;
+
// Error out if not found.
if (mod == NULL) {
/* Start Compatibility hack: Remove once everyone is using NODE_MODULE macro */
- node_module_struct compat_mod;
+ memset(&compat_mod, 0, sizeof compat_mod);
+
mod = &compat_mod;
mod->version = NODE_MODULE_VERSION;
Please sign in to comment.
Something went wrong with that request. Please try again.