Skip to content
This repository
Browse code

Unbreak the Windows build

The v8 team apparently decided that all build products should go
into ./build/«type», and updated their common.gypi file to do so.
Unfortunately v8's common.gypi is only used for some targets. All
the other targets would still look in the old place to find their
their dependencies, which effectively broke the build.

In the long run it would be good for node to send all build
output to ./build too, on all platforms.

Conflicts:

	deps/v8/build/common.gypi
  • Loading branch information...
commit bd33fea732fa74d23fc31855631eba14a03a0c49 1 parent 1fb9cfc
Bert Belder piscisaureus authored isaacs committed

Showing 1 changed file with 4 additions and 0 deletions. Show diff stats Hide diff stats

  1. +4 0 deps/v8/build/common.gypi
4 deps/v8/build/common.gypi
@@ -272,6 +272,10 @@
272 272 'defines': [
273 273 'WIN32',
274 274 ],
  275 + 'msvs_configuration_attributes': {
  276 + 'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)',
  277 + 'CharacterSet': '1',
  278 + },
275 279 }],
276 280 ['OS=="win" and v8_enable_prof==1', {
277 281 'msvs_settings': {

0 comments on commit bd33fea

Please sign in to comment.
Something went wrong with that request. Please try again.