Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Commit

Permalink
windows: don't blow when a signal handler is attached
Browse files Browse the repository at this point in the history
Blowing up when the user attaches a signal handler makes no sense. Also,
in Node 0.10 signals will be supported, so allow people to get used to
it.
  • Loading branch information
piscisaureus committed Sep 3, 2012
1 parent 37f0eb8 commit ea1cba6
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/node.js
Expand Up @@ -462,6 +462,10 @@
};

startup.processSignalHandlers = function() {
// Not supported on Windows.
if (process.platform === 'win32')
return;

// Load events module in order to access prototype elements on process like
// process.addListener.
var signalWatchers = {};
Expand Down

5 comments on commit ea1cba6

@indutny
Copy link
Member

@indutny indutny commented on ea1cba6 Sep 3, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case?

@glennblock
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos!

@piscisaureus
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indutny do we really care about a test case? In master this all changes (because signals actually work to some extent). That's the one that really needs tests.

@indutny
Copy link
Member

@indutny indutny commented on ea1cba6 Sep 3, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm convinced

@springmeyer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this impacts #1553

Please sign in to comment.