Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fix race condition in test-http-exceptions.js

  • Loading branch information...
commit eda21cccb4caf0ba8be325b79c6c37ecaf1845c3 1 parent b93faf9
@ry ry authored
Showing with 13 additions and 11 deletions.
  1. +13 −11 test/simple/test-http-exceptions.js
View
24 test/simple/test-http-exceptions.js
@@ -12,7 +12,6 @@ server = http.createServer(function (req, res) {
res.write(server_response);
res.end();
});
-server.listen(PORT);
function check_reqs() {
var done_reqs = 0;
@@ -47,9 +46,18 @@ function add_client(num) {
return req;
}
-for (req_num = 0; req_num < 4 ; req_num += 1) {
- client_requests.push(add_client(req_num));
-}
+server.listen(PORT, function () {
+ for (req_num = 0; req_num < 4 ; req_num += 1) {
+ client_requests.push(add_client(req_num));
+ }
+
+ timer = setTimeout(function () {
+ process.removeListener("uncaughtException", exception_handler);
+ server.close();
+ assert.strictEqual(4, exception_count);
+ process.exit(0);
+ }, 300);
+});
function exception_handler(err) {
sys.puts("Caught an exception: " + err);
@@ -58,11 +66,5 @@ function exception_handler(err) {
}
exception_count += 1;
}
-process.addListener("uncaughtException", exception_handler);
-timer = setTimeout(function () {
- process.removeListener("uncaughtException", exception_handler);
- server.close();
- assert.strictEqual(4, exception_count);
- process.exit(0);
-}, 300);
+process.addListener("uncaughtException", exception_handler);
Please sign in to comment.
Something went wrong with that request. Please try again.