Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fix comment/test for Mac getaddinfo() bug.

Note: the test case was broken because on Macintosh the client connects
synchronously. This is undesirable but ok for now.
  • Loading branch information...
commit f657a6324a08145263355c85dd37253c63c4c1b5 1 parent 2a7a2f6
@ry ry authored
Showing with 5 additions and 2 deletions.
  1. +4 −1 src/net.cc
  2. +1 −1  test/test-tcp-pingpong.js
View
5 src/net.cc
@@ -184,7 +184,10 @@ Connection::Connect (const Arguments& args)
}
#ifdef __APPLE__
- /* Bypass the thread pool and do it sync on this broken ass platform */
+ /* HACK: Bypass the thread pool and do it sync on Macintosh.
+ * Experiecing strange error where execution halts on
+ * getaddrinfo() and CPU goes to 100%. FIXME.
+ */
eio_req *req = static_cast<eio_req*>(malloc(sizeof(eio_req)));
req->data = connection;
Connection::Resolve(req);
View
2  test/test-tcp-pingpong.js
@@ -68,8 +68,8 @@ function onLoad() {
client.onEOF = function () {
};
- client.connect(port);
assertEquals("closed", client.readyState);
+ client.connect(port);
}
function onExit () {
Please sign in to comment.
Something went wrong with that request. Please try again.