Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Mar 3, 2015
  1. Julien Gilli

    src: enable strict mode in all builtin modules

    misterdjules authored
    This is a follow-up commit for b233131.
    
    It enables strict mode in all built-in modules.
    
    PR: #9302
    PR-URL: #9302
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Commits on Feb 28, 2015
  1. Julien Gilli
  2. Julien Gilli

    Merge remote-tracking branch 'upstream/v0.10' into v0.12

    misterdjules authored
    Conflicts:
    	lib/console.js
    	test/simple/test-console.js
  3. Julien Gilli

    src: fix builtin modules failing with --use-strict

    misterdjules authored
    Currently, lib/_tls_legacy.js and lib/crypto.js cannot be loaded when
    --use-strict is passed to node. In addition to that, console.trace
    throws because it uses arguments.callee.
    
    This change fixes these issues and adds a test that makes sure
    every external built-in module can be loaded with require when
    --use-strict is enabled.
    
    Please note that this change does not fix all issues with built-in
    modules' code running with --use-strict. It is very likely that some
    code in the built-in modules still fails when passing this flag.
    
    However, fixing all code would require us to enable strict mode by
    default in all builtins modules, which would certainly break existing
    applications.
    
    Fixes #9187.
    
    PR: #9237
    PR-URL: #9237
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Commits on Feb 27, 2015
  1. Michael Dawson Colin Ihrig

    test: make destroyed-socket-write2.js more robust

    mdawsonibm authored cjihrig committed
    test/simple/test-http-destroyed-socket-write2.js validates
    that you get an appropriate error when trying to write to
    a request when the response on the other side has been destroyed.
    
    The test uses http.request to get a request and then keeps writing
    to it until either it hits 128 writes or gets the expected error.
    Since the writes are asynchronous we see that the writes just end
    up adding events to the event loop, which then later get processed
    once the connection supporting the request is fully ready.
    
    The test is timing dependent and if takes too long for the connection
    to be made the limit of 128 writes is exceeded and the test fails.
    The fact that the test allows a number of writes is probably to allow
    some delay for the connection to be ready for writing.
    
    On AIX, in the default configuration using the loopback interface
    is slower and the test fails because the delay is such that many
    more writes can be queued up before the connection takes place.
    If we use the host ip instead of defaulting to the loopback then
    the test passes.
    
    The test needs to be made more robust to delays. Since each write
    simply enqueues an additional write to the event queue there is
    probably no point in doing the second write until the first has
    completed. This patch schedules the next write when the first one
    completes and allows the test to pass even if it takes longer for
    the connection to be ready for writing
    
    PR-URL: #9270
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
Commits on Feb 25, 2015
  1. Robert Kowalski Julien Gilli

    doc: add explanations for querystring

    robertkowalski authored misterdjules committed
     - add an article: `decode a non-utf8 string`
     - explain default and fallback behaviour of `querystring.unescape`
    
    PR-URL: #9259
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
  2. h7lin Julien Gilli

    doc: fix default value of opts.decodeURIComponent

    h7lin authored misterdjules committed
    In the documentation for querystring.parse, the documentation mentions
    that the default value for options.decodeURIComponent is the
    decodeURIComponent function, but it's actually the querystring.unescape
    function.
    
    PR-URL: #9259
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Commits on Feb 24, 2015
  1. Robert Kowalski Julien Gilli

    doc: remove broken link to tracing api

    robertkowalski authored misterdjules committed
    closes joyent/node-website#77
    
    PR: #9172
    PR-URL: #9172
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
Commits on Feb 20, 2015
  1. Andrei Sedoi Trevor Norris

    deps: backport a02d97e from v8 upstream

    bsnote authored trevnorris committed
    Original commit message:
    
      Fix --max_old_space_size=4096 integer overflow.
    
      BUG=v8:3857
      LOG=N
    
      Review URL: https://codereview.chromium.org/897543002
    
      Cr-Commit-Position: refs/heads/master@{#26510}
    
    PR-URL: #9200
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
  2. Trevor Norris

    smalloc: extend user API

    trevnorris authored
    node::Environment isn't accessible to user APIs, so extend smalloc to
    also accept v8::Isolate.
    
    Fixes: 75adde0 "src: remove `node_isolate` from source"
    PR-URL: iojs/io.js#905
    Reviewed-by: Fedor Indutny <fedor@indutny.com>
Commits on Feb 19, 2015
  1. Fedor Indutny Trevor Norris

    net: unref timer in parent sockets

    indutny authored trevnorris committed
    `TLSSocket` wraps the original `net.Socket`, but writes/reads to/from
    `TLSSocket` do not touch the timers of original `net.Socket`.
    
    Introduce `socket._parent` property, and iterate through all parents
    to unref timers and prevent timeout event on original `net.Socket`.
    
    Fix: #9242
    PR-URL: iojs/io.js#891
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Commits on Feb 18, 2015
  1. Julien Gilli

    console: allow Object.prototype fields as labels

    misterdjules authored
    This is a backport of 6c3647c from
    v0.12 to v0.10.
    
    Console.prototype.timeEnd() returns NaN if the timer label
    corresponds to a property on Object.prototype. In v0.12, this was fixed
    by using Object.create(null) to construct the _times object
    
    However, the version of V8 in the v0.10 branch makes this fix not work
    as expected. In v0.10, this commit changes the _times object into a
    array of objects of the form:
    
    { label: someLabel, time: staringWallClockTime }
    
    someLabel can thus be any string, including any string that represents
    any Object.prototype field.
    
    Fixes #9116.
    
    PR: #9215
    PR-URL: #9215
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  2. Sam Roberts Julien Gilli

    dgram: implicit binds should be exclusive

    sam-github authored misterdjules committed
    Server sockets should be shared by default, and client sockets should be
    exclusive by default. For net/TCP, this is how it is, for dgram/UDP, its
    a little less clear what a client socket is, but a socket that is
    auto-bound during a dgram.send() is not usefully shared among cluster
    workers, any more than an outgoing TCP connection would be usefully
    shared.
    
    Since implicit binds become exclusive, implicit/client dgram sockets can
    now be used with cluster on Windows. Before, neither explicit nor
    implicitly bound sockets could be used, causing dgram to be completely
    unsupported with cluster on Windows. After this change, they become half
    supported.
    
    PR: #8643
    Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-by: Bert Belder <bertbelder@gmail.com>
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Commits on Feb 17, 2015
  1. Bruno Jouhier Colin Ihrig

    fs: properly handle fd passed to truncate()

    bjouhier authored cjihrig committed
    Currently, fs.truncate() silently fails when a file descriptor
    is passed as the first argument. This commit changes this
    behavior to properly call fs.ftruncate().
    
    PR-URL: #9161
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
  2. Bruno Jouhier Colin Ihrig

    fs: properly handle fd passed to truncate()

    bjouhier authored cjihrig committed
    Currently, fs.truncate() silently fails when a file descriptor
    is passed as the first argument. This commit changes this
    behavior to properly call fs.ftruncate(). This commit also
    adds proper type checking to the callback provided to
    makeCallback().
    
    PR-URL: #9161
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
  3. Julien Gilli
  4. Julien Gilli

    Merge remote-tracking branch 'upstream/v0.12'

    misterdjules authored
    Conflicts:
    	src/node_version.h
  5. Julien Gilli
  6. Julien Gilli

    deps: do not add extra newline in log file

    misterdjules authored
    The commit in v0.10 (431eb17) that
    backported the original change
    (https://codereview.chromium.org/806143002) did add an extra newline
    because the logging facilities in v0.10's V8 do not add one.
    
    When merging this commit in v0.12, V8's logging facilities now
    automatically add the newline character, and the debug builds assert if
    one is already present.
  7. Julien Gilli

    deps: add test for V8 version in profiler's log

    misterdjules authored
    431eb17 had integrated the addition of
    V8's version in V8's profiler log files, without backporting the test
    that was included in the original change
    (https://codereview.chromium.org/806143002). This commit backports this
    test.
    
    The newly added test was tested with
    #9208.
Commits on Feb 16, 2015
  1. Julien Gilli

    Merge remote-tracking branch 'upstream/v0.10' into v0.12

    misterdjules authored
    Conflicts:
    	deps/v8/src/log-utils.cc
  2. Trevor Norris

    buffer: fix pool offset adjustment

    trevnorris authored
    If the Buffer allocation isn't a slice then there's no need to adjust
    the pool offset after realloc'ing the space available.
    
    Fixes: 6462519 "buffer, doc: misc. fix and cleanup"
Commits on Feb 13, 2015
  1. Colin Ihrig

    console: allow Object.prototype fields as labels

    cjihrig authored
    Console.prototype.timeEnd() returns NaN if the timer label
    corresponds to a property on Object.prototype. This commit
    uses Object.create(null) to construct the _times object.
    
    Fixes: #9069
    PR-URL: #9116
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Commits on Feb 12, 2015
  1. Herbert Vojčík Trevor Norris

    module: replace NativeModule.require

    herby authored trevnorris committed
    The NativeModule system passes NativeModule.require transparently and so
    is unnecessary to call explicitly.
    
    The only one which should have the prefix is the in line 295, where
    actually implements a big fs-based module system and actually requires a
    native module. That is left unchanged.
    
    PR-URL: #9201
    Ref: #2009
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  2. Dan Dascalescu Trevor Norris

    doc: fix code syntax

    dandv authored trevnorris committed
    Add a ';' to the end of a function call in documentation.
    
    PR-URL: #9198
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Commits on Feb 11, 2015
  1. Trevor Norris

    fs: make F_OK/R_OK/W_OK/X_OK not writable

    Jackson Tian authored trevnorris committed
    Change the fs.F_OK/R_OK/W_OK/X_OK out of fs.js will lead unexpect
    exception. Make these properties readonly.
    
    PR-URL: #9060
    [trev.norris@gmail.com test properties are read only]
    Signed-off-by: Trevor Norris <trev.norris@gmail.com>
  2. Jan Schär Trevor Norris

    test: Timeout#unref() does not return instance

    jscissr authored trevnorris committed
    Timeout#unref() call returns undefined, not this. The test already
    worked before, because the interval was still unref'd, and the test also
    succeeds without clearing the interval.
    
    PR-URL: #9171
    Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
  3. Debjeet Biswas Trevor Norris

    doc: grammar fix in smalloc

    detj authored trevnorris committed
    PR-URL: #9164
    Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
Commits on Feb 10, 2015
  1. Ben Noordhuis Trevor Norris

    lib: fix max size check in Buffer constructor

    bnoordhuis authored trevnorris committed
    A number -> uint32 type coercion bug made buffer sizes
    larger than kMaxLength (0x3fffffff) wrap around.
    
    Instead of rejecting the requested size with an exception,
    the constructor created a buffer with the wrong size.
    
    PR-URL: iojs/io.js#657
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Commits on Feb 9, 2015
  1. Trevor Norris

    asyncwrap: fix constructor condition for early ret

    trevnorris authored
    AsyncWrap should always properly propagate asynchronous calls to any
    child that is created. Regardless whether kCallInitHook is currently
    active. The previous logic would always return early if kCallInitHook
    wasn't set.
    
    PR-URL: #9146
    Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
  2. Amir Saboury Trevor Norris

    url: reslove urls with . and ..

    amir-s authored trevnorris committed
    '.' and '..' are directory specs and resolving urls with or without the
    hostname with '.' and '..' should add a trailing slash to the end of the
    url.
    
    Fixes: #8992
    PR-URL: #9010
    Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Commits on Feb 6, 2015
  1. Julien Gilli

    Now working on 0.12.1

    misterdjules authored
  2. Julien Gilli
  3. Julien Gilli

    2015.02.06, Version 0.12.0 (Stable)

    misterdjules authored
    * npm: Upgrade to 2.5.1
    
    * mdb_v8: update for v0.12 (Dave Pacheco)
  4. Forrest L Norvell Julien Gilli

    deps: upgrade npm to 2.5.1

    othiym23 authored misterdjules committed
    Fixes #9126.
    
    Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
Something went wrong with that request. Please try again.