Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on May 20, 2015
  1. @mrkmg @misterdjules

    src: fix ifdef comment

    mrkmg authored misterdjules committed
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #25274
Commits on May 14, 2015
  1. @misterdjules

    Merge remote-tracking branch 'upstream/v0.12'

    misterdjules authored
    Conflicts:
    	src/node_version.h
  2. @misterdjules

    Now working on 0.12.4

    misterdjules authored
  3. @misterdjules
  4. @misterdjules

    2015.05.13, Version 0.12.3 (Stable)

    misterdjules authored
    * V8: update to 3.28.71.19
    
    * uv: upgrade to 1.5.0
    
    * npm: upgrade to 2.9.1
    
    * V8: don't busy loop in v8 cpu profiler thread (Mike Tunnicliffe)
    
    * V8: fix issue with let bindings in for loops (adamk)
    
    * debugger: don't spawn child process in remote mode (Jackson Tian)
    
    * net: do not set V4MAPPED on FreeBSD (Julien Gilli)
    
    * repl: make 'Unexpected token' errors recoverable (Julien Gilli)
    
    * src: backport ignore ENOTCONN on shutdown race (Ben Noordhuis)
    
    * src: fix backport of SIGINT crash fix on FreeBSD (Julien Gilli)
Commits on May 13, 2015
  1. @misterdjules

    tls,crypto: revert recent cipher lists changes

    misterdjules authored
    Revert "disable RC4, add --cipher-list command line switch" and
    "tls: make --enable-legacy-cipher-list=val less verbose"
    
    This reverts commit f9291a9 and
    b5737bb.
    
    There is still some work to be done to guarantee secure defaults and a
    smooth upgrade path for v0.12.x users. Before this work is finished, we
    want to be able to release new versions of v0.12.x. So instead of
    waiting for these changes to be ready to ship, revert them and integrate
    them when they're ready to be shipped.
    
    Conflicts:
    	src/node.cc
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #25296
  2. @othiym23 @misterdjules

    deps: upgrade npm to 2.9.1

    othiym23 authored misterdjules committed
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #25289
  3. @misterdjules

    repl: make 'Unexpected token' errors recoverable

    misterdjules authored
    Fix the regexp used to detect 'Unexpected token' errors so that they can
    be considered as recoverable. This fixes the following use case:
    
    > var foo = 'bar \
    ... baz';
    undefined
    > foo
    'bar baz'
    >
    
    Fixes #8874
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #8875
Commits on May 12, 2015
  1. @orangemocha

    test,win: disable test-tls-server-verify for CI

    orangemocha authored
    test-tls-server-verify takes a lont time to execute and times
    out on the Jenkins machines.
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #25284
  2. @tunniclm @misterdjules

    deps: don't busy loop in v8 cpu profiler thread

    tunniclm authored misterdjules committed
    Backport 6964a9e0685fa186d9d9b7907be17505e839db1a from upstream v8.
    
    Original commit message:
    
      Make CPU profiler do not hog 100% of CPU.
    
      Tick event processor should not stay in a tight loop
      when there's nothing to do. It can go sleep until next sample event.
    
      LOG=N
      BUG=v8:3967
      Committed: https://crrev.com/6964a9e0685fa186d9d9b7907be17505e839db1a
      Cr-Commit-Position: refs/heads/master@{#28211}
    
    Fixes #25137
    Related: #9439, #8789
    
    PR: #25268
    PR-URL: #25268
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
  3. @trevnorris @misterdjules

    build: fix use of strict aliasing

    trevnorris authored misterdjules committed
    The -fno-strict-aliasing flag was added to fix compilation warnings when
    building Node.js with GCC <= 4.4
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #9179
    
    PR: #25141
    PR-URL: #25141
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
  4. @saghul @misterdjules

    deps: update libuv to 1.5.0

    saghul authored misterdjules committed
    PR: #25141
    PR-URL: #25141
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
Commits on May 6, 2015
  1. @mhdawson

    test: Extend timeout due to failure on AIX

    mhdawson authored mhdawson committed
    The loopback on AIX is slower by default than on other platforms
    and we've seen a number of tests fail on AIX for this reason. This
    looks to be another instance.  Changing the test to bind to the
    host ip instead of the loopback makes it pass reliably.
    
    This change extends the timeout so that it passes reliably on AIX
    even with the slower loopback behaviour
    
    	modified:   test/simple/test-tls-wrap-timeout.js
    
    Reviewed-By: coln Ihrig <cjihrig@gmail.com>
    PR-URL: #25138
Commits on May 1, 2015
  1. @othiym23 @misterdjules

    deps: upgrade npm to 2.8.4

    othiym23 authored misterdjules committed
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #20311
Commits on Apr 30, 2015
  1. @misterdjules

    test: make test-npm uses custom node, not global

    misterdjules authored
    When running make test-npm, make would use the node binary available in
    the PATH, which would most of the time not be the same binary as the one
    built from the source tree from where the make test-npm command in run.
    
    This can be confusing, as it can lead users to think that they tested
    npm with the version of node that was built from the current checkout of
    the source tree when it would actually run the tests with a completely
    different version.
    
    This change modifies the PATH environment variable for all commands that
    need to run the node binary to run npm's tests by adding the root of the
    local checkout as the first entry, so that the custom built node is
    always used.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #9107
  2. @misterdjules

    test: add test for let bindings in for loops

    misterdjules authored
    0724602 floats a patch on V8 that fixes
    issue #9113 that would cause let bindings and continue statements in for
    loops to not work properly.
    
    This change adds a regression test that fails if that patch is not
    properly floated, thus preventing us from not floating that patch after
    future V8 upgrades.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #23948
  3. @ajklein @misterdjules

    v8: fix issue with let bindings in for loops

    ajklein authored misterdjules committed
    Backport b17eaaa5755e625493c5fe537f42b58838923c52 from upstream v8.
    
    Original commit message:
      Fix desugaring of let bindings in for loops to handle continue properly
    
      This requires putting the original loop's body inside an inner for loop (with
      the same labels as the original loop) and re-binding the temp variables in its
      "next" expression. A second flag is added to the desugared code to ensure the
      loop body executes at most once per loop.
    
      BUG=v8:3683
      LOG=y
    
      Review URL: https://codereview.chromium.org/720863002
    
      Cr-Commit-Position: refs/heads/master@{#25363}
    
    Fixes #9113 and #14411.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #23948
Commits on Apr 29, 2015
  1. @misterdjules

    build: fix build for SmartOS

    misterdjules authored
    This change in V8: https://code.google.com/p/v8/source/detail?r=22210
    has introduced a method named OS::GetCurrentThreadId which fails to
    compile on OSes where a "gettid" syscall does not exist.
    
    This build issue has been fixed upstream by several changes:
    - https://code.google.com/p/v8/source/detail?r=23459.
    - https://codereview.chromium.org/649553002
    - https://codereview.chromium.org/642223003
    
    Another minor fix to the upstream changes was also necessary.
    See https://code.google.com/p/v8/issues/detail?id=3620 for
    more information.
    
    The other build issue was due to the fact that alloca.h is not included
    by other system includes on SmartOS, which is assumed by V8.
    
    Built and tested on Linux, MacOS X, Windows and SmartOS.
    
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
  2. @yury-s @misterdjules

    deps: backport use strict fix for V8 debugger

    yury-s authored misterdjules committed
    Backport 2ad2237507c5b5f9047b8d94d2f4997327eae852 from V8.
    
    Original commit message:
    
      Fix Unhandled ReferenceError in debug-debugger.js
    
      This fixes following exception in Sky on attempt to set a breakpoint
      "Unhandled: Uncaught ReferenceError: break_point is not defined"
      I think this happens in Sky but not in Chrome because Sky scripts are executed in strict mode.
    
      BUG=None
      LOG=N
      R=yangguo@chromium.org
    
      Review URL: https://codereview.chromium.org/741683002
    
      Cr-Commit-Position: refs/heads/master@{#25415}
    
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
  3. @davepacheco @misterdjules

    mdb_v8: fix dictionary properties access

    davepacheco authored misterdjules committed
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
  4. @refack @misterdjules

    deps: fix postmortem-metadata generator in v8

    refack authored misterdjules committed
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
  5. @trevnorris @misterdjules

    deps: apply floating irhydra patch to v8

    trevnorris authored misterdjules committed
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
  6. @trevnorris @misterdjules

    deps: update V8 to 3.28.71.19

    trevnorris authored misterdjules committed
    The 3.28.73 update was technically unstable code. This reverts the code
    to the latest 3.28 stable release.
    
    Reviewed-By: Trevor Norris <trev.norris@gmail.com>
    PR-URL: #18206
Commits on Apr 28, 2015
  1. @misterdjules

    net: do not set V4MAPPED on FreeBSD

    misterdjules authored
    V4MAPPED is not supported on recent FreeBSD versions, at least on 10.1.
    Thus, do not set this flag in net.connect on FreeBSD.
    
    Fixes #8540 and #9204.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #18204
Commits on Apr 23, 2015
  1. @orangemocha

    build,win: set env before generating projects

    orangemocha authored
    vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
    so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
    defaults to 'auto' and selects VS 2005.
    
    vcbuild sets the environment in the current shell, so this issue
    would manifest itself only on the first invocation of the script
    in any given shell windows.
    
    Reviewed-By: Julien Gilli <jgilli@fastmail.fm>
    PR-URL: #20109
Commits on Apr 14, 2015
  1. @misterdjules

    src: fix backport for SIGINT crash fix on FreeBSD

    misterdjules authored
    61fe1fe backported
    b64983d77cc3ed2e4b585f3bfc8ed23802389a52 from io.js, but failed to
    change nullptr to NULL, which lead to a build break on FreeBSD since the
    current build system doesn't enable support for C++11.
    
    This change replaces nullptr by NULL, and has been tested on
    FreeBSD 10.1-RELEASE-p8.
    
    Fixes #9326.
    
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    PR-URL: #14819
  2. @misterdjules

    debugger: don't spawn child process in remote mode

    Jackson Tian authored misterdjules committed
    When debug in remote mode with host:port or pid, the interface
    spawn child process also. If the debugger agent is running, will
    get following output:
    
    ```
    < Error: listen EADDRINUSE :::5858
    <     at Object.exports._errnoException (util.js:734:11)
    <     at exports._exceptionWithHostPort (util.js:757:20)
    <     at Agent.Server._listen2 (net.js:1155:14)
    <     at listen (net.js:1181:10)
    <     at Agent.Server.listen (net.js:1268:5)
    <     at Object.start (_debug_agent.js:21:9)
    <     at startup (node.js:68:9)
    <     at node.js:799:3
    ```
    
    This fix won't spawn child process and no more error message was
    shown.
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #14172
  3. @misterdjules

    debugger: improve help information

    Jackson Tian authored misterdjules committed
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #14172
Commits on Apr 13, 2015
  1. @bnoordhuis @mhdawson

    src: backport ignore ENOTCONN on shutdown race

    bnoordhuis authored mhdawson committed
    This is a backport of ea37ac0
    
    Original commit message:
    
      On AIX, OS X and the BSDs, calling shutdown() on one end of a pipe
      when the other end has closed the connection fails with ENOTCONN.
    
      The sequential/test-child-process-execsync test failed sporadically
      because of a race between the parent and the child where one closed
      its end of the pipe before the other got around to calling shutdown()
      on its end of the pipe.
    
      Libuv is not the right place to handle that because it can't tell if
      the ENOTCONN error is genuine but io.js can.
    
      Refs: libuv/libuv#268
      PR-URL: iojs#1214
      Reviewed-By: Bert Belder <bertbelder@gmail.com>
    
    Fixes: #9444.
    
    Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
    PR-URL: #14480
  2. @gireeshpunathil @mhdawson

    test: immunize data flow from packet size and order

    gireeshpunathil authored mhdawson committed
    simple/test-child-process-stdout-flush-exit.js fails with an assertion.
    The root cause for this assertion is that the expected boolean value of
    true for the variable gotBye was false. This is set to true when the
    piped stdout stream of the child writes the end token "goodbye". So the
    error message would indicate that the end token was never received by
    the parent, but in fact it did. The only difference is that the first
    chunk itself had both 'hello' and 'goodbye' (as well as the filler
    words in between) in AIX, while Linux receives them separately.
    
    While this issue is not reproducible in Linux, the number of bytes
    received each time a callback is called is not consistent across runs,
    which is ratified as the actual content size of a UNIX domain data packet
    is determined outside of the node's logic, instead in OS tunables, as well
    as the runtime context of data transfer (depending on contigeous free
    memory available in OS data structures at the time of sending).
    In addition, around 200 filler words sent in between the 'hello' and
    'goodbye' seem to indicate that the coalescence of chunks was a possibility
    in Linux as well, and was devised to separate the first word from the last,
    through an arbitrary delimiter.
    
    Parser logic seem to be rigid and have assumptions about the order and size
    of the data arrival. For example, it checks for 'goodbye' only when it does
    not find 'hello' in it, as if they would always come separately. This
    exclusiveness is what makes the test to fail in AIX.
    
    Reviewed-By:
    PR-URL: #14410
Commits on Apr 8, 2015
  1. @jasnell

    test: fixing a few nits in the test

    jasnell authored
    typo and unnecessary options init
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #14383
  2. @jasnell

    tls: pass in isolate with define string constant + style nits

    jasnell authored
    Per the commit feedback, fix up style nits and pass in the
    isolate with the NODE_DEFINE_STRING_CONSTANT macro.
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #14383
  3. @jasnell

    tls: make --enable-legacy-cipher-list less verbose

    jasnell authored
    Based on commit feedback, make the PrintHelp for
    --enable-legacy-cipher-list less verbose.
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #14383
  4. @jasnell

    tls: command-line switch and envar cipher-list override

    jasnell authored
    Add command line switches and environment variables to override
    the default cipher suite in tls.js
    
    `--cipher-list` and `NODE_CIPHER_LIST` can be used to completely
    override the default cipher list with a given value.
    
    `--enable-legacy-cipher-list` and `NODE_LEGACY_CIPHER_LIST` can
    be used to reset the default cipher list back to a known legacy
    value shipped in prior Node.js releases
    
    A new `getLegacyCiphers` method on the tis module allows
    programmatic access to the old cipher list defaults.
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #14383
  5. @jasnell

    tls: more secure defaults

    jasnell authored
    Port of io.js commit: iojs/io.js@77f3586
    
    Original commit message:
    
    This updates the default cipher suite to an more secure list, which
    prefers strong ciphers with Forward Secrecy. Additionally, it enables
    `honorCipherOrder` by default.
    
    Noteable effect of this change is that the insecure RC4 ciphers are
    disabled and that Chrome negotiates a more secure ECDHE cipher.
    
    Reviewed-By: James M Snell <jasnell@gmail.com>
    PR-URL: #14383
Something went wrong with that request. Please try again.