Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
branch: reviewme2
Commits on Mar 4, 2013
  1. @piscisaureus
  2. @piscisaureus
  3. @isaacs

    stream: Don't require read(0) to emit 'readable' event

    isaacs authored
    When a readable listener is added, call read(0) so that data will flow in, up to
    the high water mark.
    
    Otherwise, it's somewhat confusing that you have to listen for readable,
    and ALSO call read() (when it will certainly return null) just to get some
    data out of the stream.
    
    See: #4720
  4. @upsuper @bnoordhuis

    dns: fix ReferenceError in resolve() error path

    upsuper authored bnoordhuis committed
    A typo in the variable name makes it throw a ReferenceError instead of
    the expected "Unknown type" error when dns.resolve() is passed a bad
    record type argument.
    
    Fixes the following exception:
    
      ReferenceError: type is not defined
        at Object.exports.resolve (dns.js:189:40)
        at /Users/bnoordhuis/src/master/test/simple/test-c-ares.js:48:9
        <snip>
  5. @rvagg @isaacs

    link to LevelUP modules wiki page, not level-hooks

    rvagg authored isaacs committed
  6. @isaacs

    cluster: Rename destroy() to kill(signal=SIGTERM)

    isaacs authored
    Fix #4133, bringing the cluster worker API more in line with the
    child process API.
  7. @isaacs

    stream: Writable.end(chunk) after end is an error

    isaacs authored
    Calling end(data) calls write(data).  Doing this after end should
    raise a 'write after end' error.
    
    However, because end() calls were previously ignored on already
    ended streams, this error was confusingly suppressed, even though the
    data never is written, and cannot get to the other side.
    
    This is a re-hash of 5222d19, but
    without assuming that the data passed to end() is valid, and thus
    breaking a bunch of tests.
Commits on Mar 3, 2013
  1. @cannona @isaacs

    doc: Add crypto.pseudoRandomBytes, fix typo

    cannona authored isaacs committed
  2. @cxreg @isaacs

    make repl compatible with domains

    cxreg authored isaacs committed
    The try/catch in repl.js keeps any active domain from catching the
    error.  Since the domain may not even be enterd until the code is run,
    it's not possible to avoid the try/catch, so emit on the domain when an
    error is thrown.
  3. @bnoordhuis

    Revert "stream: Writable.end(chunk) after end is an error"

    bnoordhuis authored
    It's breaking ~22 tests, Needs further investigation.
    
    This reverts commit 5222d19.
  4. @isaacs

    doc: Typo in ChangeLog

    isaacs authored
    downgrade TO 3.14
  5. @isaacs

    stream: Writable.end(chunk) after end is an error

    isaacs authored
    Calling end(data) calls write(data).  Doing this after end should
    raise a 'write after end' error.
    
    However, because end() calls were previously ignored on already
    ended streams, this error was confusingly suppressed, even though the
    data never is written, and cannot get to the other side.
Commits on Mar 2, 2013
  1. @isaacs

    events: Handle emit('error') before ctor

    isaacs authored
    The previous commit did not handle the case when the event type
    is 'error', since that is checked before reading the handler.
  2. @isaacs
  3. @bnoordhuis

    Merge remote-tracking branch 'origin/v0.8'

    bnoordhuis authored
    Conflicts:
    	doc/api/http.markdown
    	test/simple/test-crypto.js
  4. @bnoordhuis

    test: make simple/test-dgram-pingpong respect PORT

    bnoordhuis authored
    Don't use hard-coded port numbers, use common.PORT instead.
    
    Should fix the occasional Jenkins failure; the builds run in parallel.
  5. @isaacs
  6. @isaacs

    net: Provide better error when writing after FIN

    isaacs authored
    The stock writable stream "write after end" message is overly vague, if
    you have clearly not called end() yourself yet.
    
    When we receive a FIN from the other side, and call destroySoon() as a
    result, then generate an EPIPE error (which is what would happen if you
    did actually write to the socket), with a message explaining what
    actually happened.
  7. @raymondfeng @piscisaureus

    windows/msi: fix msi build issue with WiX 3.7/3.8

    raymondfeng authored piscisaureus committed
    The `heat` tool that gathers NPM source files wasn't getting called.
    Closes #4896
  8. @tjfontaine @bnoordhuis

    test: optionally set common.PORT via env variable

    tjfontaine authored bnoordhuis committed
    This is a back-port of commit 17a8126 from the master branch.
  9. @bnoordhuis

    test: unlink temp file at test start

    bnoordhuis authored
    The file has a long name that's apparently impossible to remove with
    `git clean` on Windows.
  10. @trevnorris @isaacs

    events: add type checks to once

    trevnorris authored isaacs committed
    Also cleanup unnecessary use of "self" since it will always be called
    using .apply() from emit.
  11. @trevnorris @isaacs

    events: emit cleanup

    trevnorris authored isaacs committed
    Cleanup check logic. Place vars at top. Remove PROCESS.
  12. @trevnorris @isaacs

    events: additional type check for addListener

    trevnorris authored isaacs committed
    Check both passed args to addListener.
    
    Place var at beginning.
  13. @trevnorris @isaacs

    events: _events to object and undefined not null

    trevnorris authored isaacs committed
    By making sure the _events is always an object there is one less check
    that needs to be performed by emit.
    
    Use undefined instead of null. typeof checks are a lot faster than
    isArray.
    
    There are a few places where the this._events check cannot be removed
    because it is possible for the user to call those methods after using
    utils.extend to create their own EventEmitter, but before it has
    actually been instantiated.
  14. @trevnorris @isaacs

    events: removeListener add checks and cleanup

    trevnorris authored isaacs committed
    Remove unecessary splice for single listener events. Add type check for
    "type" argument.
  15. @trevnorris @isaacs

    events: type check listeners

    trevnorris authored isaacs committed
    Make sure the argument passed is a string. Also use typeof === function
    check instead of isArray().
  16. @trevnorris @isaacs

    events: simplify removeAllListeners logic

    trevnorris authored isaacs committed
    Unnecessary checks were being performed on if the event existed before
    being removed.
    
    _events starts out as null, so reset to null when emptied.
    
    Checking typeof is a lot cheaper than isArray().
  17. @trevnorris @isaacs

    events: type check setMaxListeners, cleanup throws

    trevnorris authored isaacs committed
    setMaxListeners will now make sure a positive number is passed. Also
    throwing more definitive Error types.
  18. @trevnorris @isaacs

    events: ensure usingDomain is always boolean

    trevnorris authored isaacs committed
    Small addition to ensure that exports.usingDomains is always a bool.
  19. @trevnorris @isaacs

    events: add check for listeners length

    trevnorris authored isaacs committed
    Ability to return just the length of listeners for a given type, using
    EventEmitter.listenerCount(emitter, event). This will be a lot cheaper
    than creating a copy of the listeners array just to check its length.
  20. @bnoordhuis

    crypto: don't assert when calling Cipher#final() twice

    bnoordhuis authored
    Remove the assert() that triggered when Cipher#final() or
    Decipher#final() was called twice.
    
    Fixes #4886.
  21. @bnoordhuis
  22. @isaacs

    doc change for Readable._read()

    Lars-Magnus Skog authored isaacs committed
Commits on Mar 1, 2013
  1. @isaacs
Something went wrong with that request. Please try again.