Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Sep 15, 2011
  1. @isaacs

    Fix #1707 hasOwnProperty usage

    isaacs authored
    If hasOwnProperty is overridden, then calling `obj.hasOwnProperty(prop)`
    can fail.  Any time a dictionary of user-generated items is built, we
    cannot rely on hasOwnProperty being safe, so must call it from the
    Object.prototype explicitly.
  2. @isaacs
Commits on Sep 14, 2011
  1. @bnoordhuis

    test: add http multi-line header test

    bnoordhuis authored
    Test case for #1569. Verify that http_parser parses multi-line headers.
Commits on Sep 4, 2011
  1. @koichik
Commits on Sep 3, 2011
  1. @koichik
Commits on Sep 2, 2011
  1. @koichik
Commits on Aug 25, 2011
  1. @TooTallNate @bnoordhuis

    util: isRegExp() should not call toString() on its argument

    TooTallNate authored bnoordhuis committed
    An overloaded toString() method may have side effects
    so don't call it for a simple type check.
    Back-port of 54b409d to the v0.4 branch.
Commits on Aug 20, 2011
  1. @ry

    Fix #1563. overflow in ChildProcess custom_fd.

    ry authored
    Backported from master f5db3f1
Commits on Aug 12, 2011
  1. @bnoordhuis
Commits on Aug 11, 2011
  1. @isaacs
Commits on Jul 29, 2011
  1. @koichik
Commits on Jul 23, 2011
  1. @cesare @koichik

    Fix crypto encryption/decryption with Base64.

    cesare authored koichik committed
    Fixes #738.
    Fixes #1205.
Commits on Jul 21, 2011
  1. @trentm @bnoordhuis

    http: fix setting ServerResponse.statusCode in writeHead

    trentm authored bnoordhuis committed
    Fixes #1374.
Commits on Jul 19, 2011
  1. @isaacs
  2. @reid @koichik

    Properly respond to HEAD during end(body) hot path

    reid authored koichik committed
    During write(), _hasBody is checked to make sure a body
    is allowed -- this is now also checked during end(body)
    when write() isn't used.
    Concise final chunk for HEAD req's res.end(data).
    Instead of simply clearing data, check _hasBody
    earlier to avoid sending cruft when chunkedEncoding
    is used.
    Fixes #1291.
Commits on Jul 14, 2011
  1. @koichik

    Add tests for #1085 and #1304

    koichik authored
    Fixes #1327.
Commits on Jul 13, 2011
  1. @koichik

    Fix Buffer drops last null character in UTF-8

    koichik authored
        $ node
        > buf = new Buffer('\0')
        <Buffer >
        > buf.length
        > buf = new Buffer(1)
        <Buffer 28>
        > buf.write('\0')
    Fixes #394.
    Fixes #1210.
  2. @koichik

    Improvements AssertionError message

    koichik authored
    Fixes #217.
Commits on Jul 7, 2011
  1. @bnoordhuis
Commits on Jul 4, 2011
  1. @bnoordhuis
  2. @bnoordhuis

    Clean up temporary file on exit.

    bnoordhuis authored
    Unbreaks test/simple/test-http-get-pipeline-problem.js,
    it assumed a fixed number of files in the tmp directory.
Commits on Jul 1, 2011
  1. @ry

    Fixes #877. Don't wait for socket pool to establish connections.

    ry authored
    Thanks to Yann Biancheri for putting together an initial test.
Commits on Jun 20, 2011
  1. @koichik @ry

    Fix -e/--eval can't load module from node_modules

    koichik authored ry committed
    With -e or --eval, require() can load module using relative path.
        node -e 'require("./foo")'
    But it can't load module from node_modules directory.
        node -e 'require("foo")'
    Fixes #1196.
Commits on Jun 14, 2011
  1. @ry

    Support for signature verification with RSA/DSA public keys

    Mark Cavage authored ry committed
    Fixes #1166.
Commits on May 27, 2011
  1. @ryanpetrello @isaacs

    Close #562 Close #1078 Parse file:// urls properly

    ryanpetrello authored isaacs committed
    The file:// protocol *always* has a hostname; it's frequently
    abbreviated as an empty string, which represents 'localhost'
    According to RFC 1738 (
    A file URL takes the form:
    where <host> is the fully qualified domain name of the system on
    which the <path> is accessible...
    As a special case, <host> can be the string "localhost" or the empty
    string; this is interpreted as 'the machine from which the URL is
    being interpreted'.
Commits on May 24, 2011
  1. @felixge @ry

    Fix error handling bug in stream.pipe()

    felixge authored ry committed
    Problem: Since stream.pipe() is registering it's own error handlers on
    the source and destination stream, it needs to replicate the
    EventEmitter 'error' emitting semantics of throwing an error if there
    are no other listeners. However, there was a off-by-one error because
    the check for remaining listeners was done after cleanup() which means
    the pipe's own listener was no longer included.
    This would cause 'error' events on either the dest or the source to
    throw if there was one other error listener, and while swallowing
    the 'error' event if there was no other listener.
    Solution: I added a test demonstrating the two issues and fixed the
    problem by correcting the off-by-one error.
    Fixes #1095.
Commits on May 20, 2011
  1. @ry
  2. @DTrejo @ry

    Add test for agent upgrade and example in docs

    DTrejo authored ry committed
Commits on May 19, 2011
  1. @ry

    Fix buffer test

    ry authored
  2. @ry
Commits on May 16, 2011
  1. @ry

    Remove 'binary' encoding assert - add tests

    ry authored
    Don't write large characters to buffers with binary encoding. You will be
    silently injured.
  2. @koichik @ry

    Fix dns.resolve() with 'PTR' throws Error: Unknown type "PTR"

    koichik authored ry committed
    Fixes #1038
Commits on May 14, 2011
  1. @koichik @ry

    Fix event listener leak check timing

    koichik authored ry committed
    Fixes #1041.
  2. @felixge @ry

    Error argument for http.ServerRequest 'close'

    felixge authored ry committed
    Problem: It was not possible to detect the reason for a premature
    connection termination in http requests.
    This patch provides a new `err` argument to the 'close' event which
    can be inspected to differentiate between a timeout and a client
    actively terminating the connection.
    Also contains tests for this new behavior for http and https.
  3. @felixge @ry

    Make https 'timeout' events bubble up

    felixge authored ry committed
    Also adds a test case for it.
Something went wrong with that request. Please try again.