Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Feb 2, 2012
  1. @bnoordhuis

    buffers: fix intermittent out of bounds error

    bnoordhuis authored
    The base64 decoder would intermittently throw an out-of-bounds exception when
    the buffer in `buf.write('', 'base64')` was a zero-sized buffer located at the
    end of the slab.
    
    Fixes #2657.
  2. @bnoordhuis

    buffers: honor length argument in base64 decoder

    bnoordhuis authored
    Honor the length argument in `buf.write(s, 0, buf.length, 'base64')`. Before
    this commit, the length argument was ignored. The decoder would keep writing
    until it hit the end of the buffer. Since most buffers in Node are slices of
    a parent buffer (the slab), this bug would overwrite the content of adjacent
    buffers.
    
    The bug is trivially demonstrated with the following test case:
    
        var assert = require('assert');
        var a = Buffer(3);
        var b = Buffer('xxx');
        a.write('aaaaaaaa', 'base64');
        assert.equal(b.toString(), 'xxx');
    
    This commit coincidentally also fixes a bug where Buffer._charsWritten was not
    updated for zero length buffers.
Commits on Nov 9, 2011
  1. @bnoordhuis
Commits on Oct 19, 2011
  1. @koichik

    buffer: use NO_NULL_TERMINATION flag

    koichik authored
    Refs #394.
    Fixes #1902.
Commits on Sep 8, 2011
  1. @ry

    Merge remote branch 'origin/v0.4'

    ry authored
    Conflicts:
    	lib/net.js
    	test/simple/test-buffer.js
Commits on Sep 3, 2011
  1. @koichik
Commits on Sep 2, 2011
  1. @koichik
Commits on Aug 26, 2011
  1. @ry

    Fix build - due to V8 API change

    ry authored
Commits on Aug 2, 2011
  1. @piscisaureus
Commits on Jul 26, 2011
  1. @bnoordhuis
  2. @bnoordhuis
Commits on Jul 14, 2011
  1. @ry

    Merge branch 'v0.4'

    ry authored
    Conflicts:
    	deps/libev/wscript
    	doc/api/modules.markdown
Commits on Jul 13, 2011
  1. @koichik

    Fix Buffer drops last null character in UTF-8

    koichik authored
    Reproduce:
    
        $ node
        > buf = new Buffer('\0')
        <Buffer >
        > buf.length
        0
        > buf = new Buffer(1)
        <Buffer 28>
        > buf.write('\0')
        0
    
    Fixes #394.
    Fixes #1210.
Commits on May 20, 2011
  1. @ry

    Merge branch 'v0.4'

    ry authored
    Conflicts:
    	lib/crypto.js
    	lib/tls.js
Commits on May 19, 2011
  1. @ry
Commits on May 6, 2011
  1. @kkaefer @ry

    Add Buffer::fill method to do memset

    kkaefer authored ry committed
    Fixes #477.
Commits on Apr 14, 2011
  1. @ry

    Merge branch 'v0.4'

    ry authored
    Conflicts:
    	src/platform_sunos.cc
    	test/simple/test-os.js
Commits on Apr 13, 2011
  1. @koichik @ry

    Fix Buffer.write() with UCS-2 should not be write partial char

    koichik authored ry committed
    closes #916.
Commits on Mar 22, 2011
  1. @ry

    Merge branch 'v0.4'

    ry authored
    Conflicts:
    	src/node_version.h
  2. @ry

    Guard failed buffer constructions.

    ry authored
    Thanks to Jeremy Barnes for pointing it out.
Commits on Mar 15, 2011
  1. @ry

    Merge branch 'v0.4'

    ry authored
    Conflicts:
    	src/node_version.h
  2. @ry

    Update copyright headers

    ry authored
Commits on Feb 20, 2011
  1. @isaacs @ry

    Closes GH-695 Add 'hex' encoding to Buffer

    isaacs authored ry committed
Commits on Feb 15, 2011
  1. @ry

    Revert "buffer.toString() shouldn't include null values"

    ry authored
    This reverts commit 909a5b3.
    
    Will fix inside V8's String::New instead.
Commits on Feb 14, 2011
  1. @ry
Commits on Feb 7, 2011
  1. @kkaefer @ry

    UCS-2 support

    kkaefer authored ry committed
    Closes GH-644.
Commits on Jan 18, 2011
  1. @piscisaureus

    Clean up the way windows headers are included

    piscisaureus authored
    Plus make inclusion order a little more consistent in general
Commits on Dec 20, 2010
  1. @piscisaureus
  2. @piscisaureus
Commits on Dec 3, 2010
  1. @brapse @ry

    Check buffer length using string length

    brapse authored ry committed
       + Utf8Length is really slow but has the same semantics in this case
Commits on Nov 24, 2010
  1. @thughes @ry
Commits on Nov 21, 2010
  1. @ry

    Revert "Merge branch 'writev'"

    ry authored
    This reverts commit cd9515e, reversing
    changes made to df46c8e.
    
    Too slow. Needs more work.
Commits on Nov 20, 2010
  1. @ry
Commits on Nov 19, 2010
  1. @ry

    Small clean ups

    ry authored
  2. @ry

    Support encoding

    ry authored
Something went wrong with that request. Please try again.