Skip to content
This repository

Feb 02, 2012

  1. Ben Noordhuis

    buffers: fix intermittent out of bounds error

    The base64 decoder would intermittently throw an out-of-bounds exception when
    the buffer in `buf.write('', 'base64')` was a zero-sized buffer located at the
    end of the slab.
    
    Fixes #2657.
    bnoordhuis authored
  2. Ben Noordhuis

    buffers: honor length argument in base64 decoder

    Honor the length argument in `buf.write(s, 0, buf.length, 'base64')`. Before
    this commit, the length argument was ignored. The decoder would keep writing
    until it hit the end of the buffer. Since most buffers in Node are slices of
    a parent buffer (the slab), this bug would overwrite the content of adjacent
    buffers.
    
    The bug is trivially demonstrated with the following test case:
    
        var assert = require('assert');
        var a = Buffer(3);
        var b = Buffer('xxx');
        a.write('aaaaaaaa', 'base64');
        assert.equal(b.toString(), 'xxx');
    
    This commit coincidentally also fixes a bug where Buffer._charsWritten was not
    updated for zero length buffers.
    bnoordhuis authored

Nov 09, 2011

  1. Ben Noordhuis

    Remove stray NODE_MODULE() semi-colons.

    bnoordhuis authored

Oct 19, 2011

  1. Koichi Kobayashi

    buffer: use NO_NULL_TERMINATION flag

    Refs #394.
    Fixes #1902.
    koichik authored

Sep 08, 2011

  1. ry

    Merge remote branch 'origin/v0.4'

    Conflicts:
    	lib/net.js
    	test/simple/test-buffer.js
    ry authored

Sep 03, 2011

  1. Koichi Kobayashi

    buffer: write() should always set _charsWritten.

    Refs #1633.
    koichik authored

Sep 02, 2011

  1. Koichi Kobayashi

    buffer: Avoid overrun with 'binary' encoding.

    Fixes #1624.
    koichik authored

Aug 26, 2011

  1. ry

    Fix build - due to V8 API change

    ry authored

Aug 02, 2011

  1. Bert Belder

    Remove platform_win32_winsock

    piscisaureus authored

Jul 26, 2011

  1. Ben Noordhuis

    Include "platform.h", not <platform.h> - conflicts with system headers

    Fixes #1003.
    bnoordhuis authored
  2. Ben Noordhuis

    Include "platform.h", not <platform.h> - conflicts with system headers

    Fixes #1003.
    bnoordhuis authored

Jul 14, 2011

  1. ry

    Merge branch 'v0.4'

    Conflicts:
    	deps/libev/wscript
    	doc/api/modules.markdown
    ry authored

Jul 13, 2011

  1. Koichi Kobayashi

    Fix Buffer drops last null character in UTF-8

    Reproduce:
    
        $ node
        > buf = new Buffer('\0')
        <Buffer >
        > buf.length
        0
        > buf = new Buffer(1)
        <Buffer 28>
        > buf.write('\0')
        0
    
    Fixes #394.
    Fixes #1210.
    koichik authored

May 20, 2011

  1. ry

    Merge branch 'v0.4'

    Conflicts:
    	lib/crypto.js
    	lib/tls.js
    ry authored

May 19, 2011

  1. ry

    makeFastBuffer should not segfault but rather throw on non-buffer

    ry authored

May 06, 2011

  1. Konstantin Käfer

    Add Buffer::fill method to do memset

    Fixes #477.
    kkaefer authored ry committed

Apr 14, 2011

  1. ry

    Merge branch 'v0.4'

    Conflicts:
    	src/platform_sunos.cc
    	test/simple/test-os.js
    ry authored

Apr 13, 2011

  1. Koichi Kobayashi

    Fix Buffer.write() with UCS-2 should not be write partial char

    closes #916.
    koichik authored ry committed

Mar 22, 2011

  1. ry

    Merge branch 'v0.4'

    Conflicts:
    	src/node_version.h
    ry authored
  2. ry

    Guard failed buffer constructions.

    Thanks to Jeremy Barnes for pointing it out.
    ry authored

Mar 15, 2011

  1. ry

    Merge branch 'v0.4'

    Conflicts:
    	src/node_version.h
    ry authored
  2. ry

    Update copyright headers

    ry authored

Feb 20, 2011

  1. Isaac Z. Schlueter

    Closes GH-695 Add 'hex' encoding to Buffer

    isaacs authored ry committed

Feb 15, 2011

  1. ry

    Revert "buffer.toString() shouldn't include null values"

    This reverts commit 909a5b3.
    
    Will fix inside V8's String::New instead.
    ry authored

Feb 14, 2011

  1. ry

    buffer.toString() shouldn't include null values

    ry authored

Feb 07, 2011

  1. Konstantin Käfer

    UCS-2 support

    Closes GH-644.
    kkaefer authored ry committed

Jan 18, 2011

  1. Bert Belder

    Clean up the way windows headers are included

    Plus make inclusion order a little more consistent in general
    piscisaureus authored

Dec 20, 2010

  1. Bert Belder

    Fix whitespace errors introduced by porting efforts

    piscisaureus authored
  2. Bert Belder

    Fix header files for node_buffer.cc

    piscisaureus authored

Dec 03, 2010

  1. Sean Braithwaite

    Check buffer length using string length

       + Utf8Length is really slow but has the same semantics in this case
    brapse authored ry committed

Nov 24, 2010

  1. Tom Hughes

    Allocations with new[] must be freed with delete[].

    thughes authored ry committed

Nov 21, 2010

  1. ry

    Revert "Merge branch 'writev'"

    This reverts commit cd9515e, reversing
    changes made to df46c8e.
    
    Too slow. Needs more work.
    ry authored

Nov 20, 2010

  1. ry

    Inline Buffer::Length and Buffer::Data

    ry authored

Nov 19, 2010

  1. ry

    Small clean ups

    ry authored
  2. ry

    Support encoding

    ry authored
Something went wrong with that request. Please try again.