Skip to content
This repository

Oct 10, 2012

  1. Ben Noordhuis

    buffer: report proper retained size in profiler

    Make buffers report the proper retained size in heap snapshots.
    
    Before this commit, Buffer objects would show up in the heap profiler as being
    only a few hundred bytes large, even if the actual buffer was many megabytes.
    bnoordhuis authored

Aug 16, 2012

  1. Bert Belder

    Avoid compiler warning about negating unsigned value

    piscisaureus authored

Apr 17, 2012

  1. Isaac Z. Schlueter

    MakeCallback: Consistent symbol usage

    isaacs authored

Mar 30, 2012

  1. Ben Noordhuis

    buffer: fix signedness compiler warnings

    bnoordhuis authored

Mar 23, 2012

  1. Sambasiva Suda

    Avoiding unnecessary ToString() calls

    String::Utf8Value and String::AsciiValue constructors take Handle<Value>
    So no need to convert to Handle<String>
    ssuda authored bnoordhuis committed

Mar 09, 2012

  1. Ben Noordhuis

    core: use proper #include directives

    bnoordhuis authored
  2. Ben Noordhuis

    buffer: throw from constructor if length > kMaxLength

    Throw, don't abort. `new Buffer(0x3fffffff + 1)` used to bring down the process
    with the following error message:
    
      FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length
      exceeds max acceptable value
    
    Fixes #2280.
    bnoordhuis authored

Feb 23, 2012

  1. Ben Noordhuis

    Remove unused variables.

    bnoordhuis authored

Feb 21, 2012

  1. Ben Noordhuis

    buffer: support decoding of URL-safe base64

    bnoordhuis authored

Feb 06, 2012

  1. Isaac Z. Schlueter

    Merge remote-tracking branch 'ry/v0.6'

    Conflicts:
    	ChangeLog
    	deps/v8/src/version.cc
    	deps/v8/tools/gyp/v8.gyp
    	doc/about/index.html
    	doc/community/index.html
    	doc/index.html
    	doc/logos/index.html
    	doc/template.html
    	lib/path.js
    	lib/querystring.js
    	src/node_version.h
    isaacs authored
  2. Ben Noordhuis

    Revert support for isolates.

    It was decided that the performance benefits that isolates offer (faster spin-up
    times for worker processes, faster inter-worker communication, possibly a lower
    memory footprint) are not actual bottlenecks for most people and do not outweigh
    the potential stability issues and intrusive changes to the code base that
    first-class support for isolates requires.
    
    Hence, this commit backs out all isolates-related changes.
    
    Good bye, isolates. We hardly knew ye.
    bnoordhuis authored

Feb 02, 2012

  1. Ben Noordhuis

    buffers: fix intermittent out of bounds error

    The base64 decoder would intermittently throw an out-of-bounds exception when
    the buffer in `buf.write('', 'base64')` was a zero-sized buffer located at the
    end of the slab.
    
    Fixes #2657.
    bnoordhuis authored
  2. Ben Noordhuis

    buffers: honor length argument in base64 decoder

    Honor the length argument in `buf.write(s, 0, buf.length, 'base64')`. Before
    this commit, the length argument was ignored. The decoder would keep writing
    until it hit the end of the buffer. Since most buffers in Node are slices of
    a parent buffer (the slab), this bug would overwrite the content of adjacent
    buffers.
    
    The bug is trivially demonstrated with the following test case:
    
        var assert = require('assert');
        var a = Buffer(3);
        var b = Buffer('xxx');
        a.write('aaaaaaaa', 'base64');
        assert.equal(b.toString(), 'xxx');
    
    This commit coincidentally also fixes a bug where Buffer._charsWritten was not
    updated for zero length buffers.
    bnoordhuis authored

Dec 16, 2011

  1. Remove platform files, and use uv platform api

    Igor Zinkovsky authored

Dec 08, 2011

  1. ry

    Move node_buffer.cc globals to struct

    ry authored

Nov 09, 2011

  1. Ben Noordhuis

    Remove stray NODE_MODULE() semi-colons.

    bnoordhuis authored

Oct 19, 2011

  1. Koichi Kobayashi

    buffer: use NO_NULL_TERMINATION flag

    Refs #394.
    Fixes #1902.
    koichik authored

Sep 08, 2011

  1. ry

    Merge remote branch 'origin/v0.4'

    Conflicts:
    	lib/net.js
    	test/simple/test-buffer.js
    ry authored

Sep 03, 2011

  1. Koichi Kobayashi

    buffer: write() should always set _charsWritten.

    Refs #1633.
    koichik authored

Sep 02, 2011

  1. Koichi Kobayashi

    buffer: Avoid overrun with 'binary' encoding.

    Fixes #1624.
    koichik authored

Aug 26, 2011

  1. ry

    Fix build - due to V8 API change

    ry authored

Aug 02, 2011

  1. Bert Belder

    Remove platform_win32_winsock

    piscisaureus authored

Jul 26, 2011

  1. Ben Noordhuis

    Include "platform.h", not <platform.h> - conflicts with system headers

    Fixes #1003.
    bnoordhuis authored
  2. Ben Noordhuis

    Include "platform.h", not <platform.h> - conflicts with system headers

    Fixes #1003.
    bnoordhuis authored

Jul 14, 2011

  1. ry

    Merge branch 'v0.4'

    Conflicts:
    	deps/libev/wscript
    	doc/api/modules.markdown
    ry authored

Jul 13, 2011

  1. Koichi Kobayashi

    Fix Buffer drops last null character in UTF-8

    Reproduce:
    
        $ node
        > buf = new Buffer('\0')
        <Buffer >
        > buf.length
        0
        > buf = new Buffer(1)
        <Buffer 28>
        > buf.write('\0')
        0
    
    Fixes #394.
    Fixes #1210.
    koichik authored

May 20, 2011

  1. ry

    Merge branch 'v0.4'

    Conflicts:
    	lib/crypto.js
    	lib/tls.js
    ry authored

May 19, 2011

  1. ry

    makeFastBuffer should not segfault but rather throw on non-buffer

    ry authored

May 06, 2011

  1. Konstantin Käfer

    Add Buffer::fill method to do memset

    Fixes #477.
    kkaefer authored ry committed

Apr 14, 2011

  1. ry

    Merge branch 'v0.4'

    Conflicts:
    	src/platform_sunos.cc
    	test/simple/test-os.js
    ry authored

Apr 13, 2011

  1. Koichi Kobayashi

    Fix Buffer.write() with UCS-2 should not be write partial char

    closes #916.
    koichik authored ry committed

Mar 22, 2011

  1. ry

    Merge branch 'v0.4'

    Conflicts:
    	src/node_version.h
    ry authored
  2. ry

    Guard failed buffer constructions.

    Thanks to Jeremy Barnes for pointing it out.
    ry authored

Mar 15, 2011

  1. ry

    Merge branch 'v0.4'

    Conflicts:
    	src/node_version.h
    ry authored
  2. ry

    Update copyright headers

    ry authored
Something went wrong with that request. Please try again.