Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Jan 25, 2013
  1. Trevor Norris Nathan Rajlich

    buffer: slow buffer copy compatibility fix

    trevnorris authored TooTallNate committed
    Fix issue where SlowBuffers couldn't be passed as target to Buffer
    copy().
    
    Also included checks to see if Argument parameters are defined before
    assigning their values. This offered ~3x's performance gain.
    
    Backport of 16bbecc from master branch. Closes #4633.
Commits on Jan 17, 2013
  1. Ben Noordhuis

    buffer: reject negative SlowBuffer offsets

    bnoordhuis authored
    Reject negative offsets in SlowBuffer::MakeFastBuffer(), it allows
    the creation of buffers that point to arbitrary addresses.
    
    Reported by Trevor Norris.
Commits on Oct 10, 2012
  1. Ben Noordhuis

    buffer: report proper retained size in profiler

    bnoordhuis authored
    Make buffers report the proper retained size in heap snapshots.
    
    Before this commit, Buffer objects would show up in the heap profiler as being
    only a few hundred bytes large, even if the actual buffer was many megabytes.
Commits on Aug 16, 2012
  1. Bert Belder
Commits on Apr 17, 2012
  1. isaacs
Commits on Mar 30, 2012
  1. Ben Noordhuis
Commits on Mar 23, 2012
  1. Ben Noordhuis

    Avoiding unnecessary ToString() calls

    ssuda authored bnoordhuis committed
    String::Utf8Value and String::AsciiValue constructors take Handle<Value>
    So no need to convert to Handle<String>
Commits on Mar 9, 2012
  1. Ben Noordhuis
  2. Ben Noordhuis

    buffer: throw from constructor if length > kMaxLength

    bnoordhuis authored
    Throw, don't abort. `new Buffer(0x3fffffff + 1)` used to bring down the process
    with the following error message:
    
      FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length
      exceeds max acceptable value
    
    Fixes #2280.
Commits on Feb 23, 2012
  1. Ben Noordhuis

    Remove unused variables.

    bnoordhuis authored
Commits on Feb 21, 2012
  1. Ben Noordhuis
Commits on Feb 6, 2012
  1. isaacs

    Merge remote-tracking branch 'ry/v0.6'

    isaacs authored
    Conflicts:
    	ChangeLog
    	deps/v8/src/version.cc
    	deps/v8/tools/gyp/v8.gyp
    	doc/about/index.html
    	doc/community/index.html
    	doc/index.html
    	doc/logos/index.html
    	doc/template.html
    	lib/path.js
    	lib/querystring.js
    	src/node_version.h
  2. Ben Noordhuis

    Revert support for isolates.

    bnoordhuis authored
    It was decided that the performance benefits that isolates offer (faster spin-up
    times for worker processes, faster inter-worker communication, possibly a lower
    memory footprint) are not actual bottlenecks for most people and do not outweigh
    the potential stability issues and intrusive changes to the code base that
    first-class support for isolates requires.
    
    Hence, this commit backs out all isolates-related changes.
    
    Good bye, isolates. We hardly knew ye.
Commits on Feb 2, 2012
  1. Ben Noordhuis

    buffers: fix intermittent out of bounds error

    bnoordhuis authored
    The base64 decoder would intermittently throw an out-of-bounds exception when
    the buffer in `buf.write('', 'base64')` was a zero-sized buffer located at the
    end of the slab.
    
    Fixes #2657.
  2. Ben Noordhuis

    buffers: honor length argument in base64 decoder

    bnoordhuis authored
    Honor the length argument in `buf.write(s, 0, buf.length, 'base64')`. Before
    this commit, the length argument was ignored. The decoder would keep writing
    until it hit the end of the buffer. Since most buffers in Node are slices of
    a parent buffer (the slab), this bug would overwrite the content of adjacent
    buffers.
    
    The bug is trivially demonstrated with the following test case:
    
        var assert = require('assert');
        var a = Buffer(3);
        var b = Buffer('xxx');
        a.write('aaaaaaaa', 'base64');
        assert.equal(b.toString(), 'xxx');
    
    This commit coincidentally also fixes a bug where Buffer._charsWritten was not
    updated for zero length buffers.
Commits on Dec 16, 2011
  1. Remove platform files, and use uv platform api

    Igor Zinkovsky authored
Commits on Dec 8, 2011
  1. ry
Commits on Nov 9, 2011
  1. Ben Noordhuis
Commits on Oct 19, 2011
  1. Koichi Kobayashi

    buffer: use NO_NULL_TERMINATION flag

    koichik authored
    Refs #394.
    Fixes #1902.
Commits on Sep 8, 2011
  1. ry

    Merge remote branch 'origin/v0.4'

    ry authored
    Conflicts:
    	lib/net.js
    	test/simple/test-buffer.js
Commits on Sep 3, 2011
  1. Koichi Kobayashi
Commits on Sep 2, 2011
  1. Koichi Kobayashi
Commits on Aug 26, 2011
  1. ry

    Fix build - due to V8 API change

    ry authored
Commits on Aug 2, 2011
  1. Bert Belder
Commits on Jul 26, 2011
  1. Ben Noordhuis
  2. Ben Noordhuis
Commits on Jul 14, 2011
  1. ry

    Merge branch 'v0.4'

    ry authored
    Conflicts:
    	deps/libev/wscript
    	doc/api/modules.markdown
Commits on Jul 13, 2011
  1. Koichi Kobayashi

    Fix Buffer drops last null character in UTF-8

    koichik authored
    Reproduce:
    
        $ node
        > buf = new Buffer('\0')
        <Buffer >
        > buf.length
        0
        > buf = new Buffer(1)
        <Buffer 28>
        > buf.write('\0')
        0
    
    Fixes #394.
    Fixes #1210.
Commits on May 20, 2011
  1. ry

    Merge branch 'v0.4'

    ry authored
    Conflicts:
    	lib/crypto.js
    	lib/tls.js
Commits on May 19, 2011
  1. ry
Commits on May 6, 2011
  1. ry

    Add Buffer::fill method to do memset

    Konstantin Käfer authored ry committed
    Fixes #477.
Commits on Apr 14, 2011
  1. ry

    Merge branch 'v0.4'

    ry authored
    Conflicts:
    	src/platform_sunos.cc
    	test/simple/test-os.js
Commits on Apr 13, 2011
  1. Koichi Kobayashi ry

    Fix Buffer.write() with UCS-2 should not be write partial char

    koichik authored ry committed
    closes #916.
Commits on Mar 22, 2011
  1. ry

    Merge branch 'v0.4'

    ry authored
    Conflicts:
    	src/node_version.h
  2. ry

    Guard failed buffer constructions.

    ry authored
    Thanks to Jeremy Barnes for pointing it out.
Something went wrong with that request. Please try again.