Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

simple/test-tls-client-abort fails on SunOS #1583

Closed
bnoordhuis opened this Issue · 3 comments

2 participants

@bnoordhuis

The test passes on my linux machine but fails on a sunos machine. Both machines have libssl and libcrypto "0.9.8k 25 Mar 2009" installed.

The error:

$ NODE_DEBUG="net tls" ./node_g test/simple/test-tls-client-abort.js
NET: destroy 6
NET: close 6
NET: destroy null

assert.js:104
  throw new assert.AssertionError({
        ^
AssertionError: false == true
    at EventEmitter.<anonymous> (/home/ben/src/node/test/simple/test-tls-client-abort.js:40:12)
    at EventEmitter.emit (events.js:88:20)

cc @koichik

@koichik koichik referenced this issue from a commit in koichik/node
@koichik koichik test: simple/test-tls-client-abort fails on SunOS
Fixes #1583.
38d7ef1
@koichik
Owner

@bnoordhuis - Can you test 38d7ef1 on SunOS?

@bnoordhuis

@koichik - yes, that works. The output now:

$ NODE_DEBUG="net tls" ./node_g test/simple/test-tls-client-abort.js
NET: destroy 6
NET: close 6
NET: destroy null

By the way, the emitted error is this one:

{ errno: 146,
     code: 'ECONNREFUSED',
     syscall: 'connect' }

Forgot to mention that yesterday, sorry about that.

@koichik
Owner

Thanks! I will merge it later.
Probably the exception raises within doConnect().

  try {
    connect(socket.fd, port, host); // here
  } catch (e) {
    socket.destroy(e);
    return;
  }
@koichik koichik closed this in 43cdbec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.