Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Could you handle this udp error 10054 in windows? #2177

Closed
longbai opened this Issue · 4 comments

2 participants

@longbai

refer support.microsoft.com/kb/263823 socket error 10054

I am not sure this is an issue or feature. When I write a udp server, if a client is die, the error callback will raise and the socket dit not use.

So how to handle it? Ignore it in nodejs layer by refer solution or reopen in js?

Thank you.

@longbai

I test again, when meet 10054, the socket would not recv, but sendto still work. I think nodejs could raise error, but do not deactive recv event on this socket.

@longbai

I think it need add wagetlasterror() check in deps\win\udp.c. if lasterror is 10054, still add read pending in the socket in line 305. I do not know linux has same issue.

@piscisaureus

Should be fixed in 7244b9c.

@kraftbai Let me know if it works for you now.

@longbai

Sorry, I have no gyp environment and vc, I cant test it.
Thanks.

@TooTallNate TooTallNate referenced this issue from a commit in TooTallNate/node
@piscisaureus piscisaureus Add test for GH-2177 a639cf7
@alexkwolfe alexkwolfe referenced this issue from a commit in alexkwolfe/node
@piscisaureus piscisaureus Add test for GH-2177 bc99d9c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.