Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

http-parser should pause #220

Closed
ry opened this Issue · 7 comments

7 participants

@ry
ry commented

a test case for the required behavior http://gist.github.com/490989

@josh

See #337

@ry
ry commented

i plan to fix this with a change to the parser: http://github.com/ry/http-parser/tree/event_stream

@bnoordhuis

This has been fixed (I think) but interestingly, that test case causes an assertion error in V8.

#
# Fatal error in /home/bnoordhuis/src/nodejs/node/deps/v8/src/api.cc, line 2692
# CHECK(!(isolate)->external_caught_exception()) failed   
#


==== Stack trace ============================================

Security context: 0x7f3197371251 <JS Object>#0#
    1: ondata [http.js:1019] (this=0x7f31930c7321 <a Socket>>#1#,d=0x7f31930c5ff9 <a Buffer>>#2#,start=0,end=81)
    2: _onReadable [net_legacy.js:683] (this=0x7f31930c7321 <a Socket>>#1#)
    3: callback(aka onReadable) [net_legacy.js:177] (this=0x7f31930c7641 <an IOWatcher>>#3#,readable=0x7f31972fc129 <true>,writable=0x7f31972fc169 <false>)

Probably related to #1191.

@koichik
Owner

This is not fixed yet. I also sent #1040.

@ry
ry commented

@pgriess, as of today, is working on a new way of pausing the HTTP parser. Watch https://github.com/ry/http-parser/ for updates.

@trevnorris
Owner

So looks like it has a fix in v0.8, and this won't function the same in v0.9 once streams2 is merged. Seems to be fixed.

@isaacs isaacs closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.