Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

dtrace ustack helper improvements #2852

Closed
davepacheco opened this Issue · 0 comments

2 participants

@davepacheco
Owner

There are a few issues with the current DTrace ustack helper:

  • It sometimes produces incomplete output. Instead of saying "func at file.js position 123", it will say " at position 123". This turned out to be a result of catching V8 during GC, where it's twiddled the last bits of various pointers, causing the helper to read the wrong memory.
  • There are certain types of internal frames where there's a Code object rather than a JSFunction object on the stack. Currently, the helper simply doesn't translate it at all, leaving you with a hex address. This interferes with stack coalescing (as via Brendan Gregg's FlameGraph tools) because you see varying hex addresses in the stack, so they appear different even though they're pretty much indistinguishable to Node programmers.

I've already got fixes for these. There's a pull request coming shortly.

@davepacheco davepacheco referenced this issue from a commit in davepacheco/node
@davepacheco davepacheco dtrace ustack helper improvements
Fixes #2852
4c87b02
@davepacheco davepacheco referenced this issue from a commit in davepacheco/node
@davepacheco davepacheco dtrace ustack helper improvements
Fixes #2852
b4059b2
@davepacheco davepacheco referenced this issue from a commit in davepacheco/node
@davepacheco davepacheco dtrace ustack helper improvements
Fixes #2852
b78f5d3
@isaacs isaacs closed this in edea94c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.