Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

readline module should not append the 'escape' key to the current line #2876

Closed
joeferner opened this Issue · 4 comments

2 participants

@joeferner

If no modifier keys are pressed and a user presses the 'escape' key a bad character is emitted. The escape key should probably be ignored.

Example: Open a node REPL and hit the escape key.

@bnoordhuis

If no modifier keys are pressed and a user presses the 'escape' key a bad character is emitted.

It doesn't for me. With what version of Node and on what operating system are you seeing this behavior?

@joeferner

I'm using v0.6.4 on linux. I also had someone try this on a mac. But on the mac it does not show the bad character, it does add the character to the line though. So if you type "1+(escape)1(enter)" the REPL does not think the line is complete and does not execute.

@bnoordhuis

Right, I see what you mean and that issue still exists in the current master. Want to try your hand at a patch?

@Southern Southern referenced this issue from a commit in Southern/node
@Southern Southern Readline escape error fixed (#2876) 6006ad6
@Southern Southern referenced this issue
Closed

Readline Fix #2881

@Southern Southern referenced this issue from a commit in Southern/node
@Southern Southern Readline fix for #2876. f9a6ff7
@bnoordhuis bnoordhuis closed this in c84b3c4
@bnoordhuis

Fixed in c84b3c4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.