Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Crash on XP (Perf Counters) #4462

Closed
deanm opened this Issue · 2 comments

3 participants

@deanm

I am building from the master branch on an xp sp3 machine w/ vs2010. It looks like recently there was support added for the windows perf counters (InitPerfCountersWin32). However, it looks like functions such as PerfStartProviderEx are only available since Vista. There is a runtime check for advapi32.dll, but not for the individual GetProcAddress calls. Easiest solution would just be to add a NULL check on the dynamic function lookups.

I could write a patch, but basically:

if (!perfctr_startProvider) return;

@deanm

I guess that should be directed @sblom.

@sblom

Investigating.

@piscisaureus piscisaureus closed this issue from a commit
@sblom sblom windows: fix perfctr crash on XP and 2003
Some performance counter related functions are not available on Windows
XP and Windows Server 2003, which caused node to call a NULL pointer.

Closes #4462
Closes #4511
5a39df4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.