Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Set `process.platform` to "darwin" on OS X. #2519

Closed
wants to merge 2 commits into from

2 participants

@TooTallNate
Owner

This is consistent with the old waf build system, and doesn't break old scripts that are expecting the value to be "darwin".

Fixes #2518.

TooTallNate added some commits
@TooTallNate TooTallNate Set `process.platform` to "darwin" on OS X.
This is consistent with the old waf build system, and doesn't break old scripts
that are expecting the value to be "darwin".

Fixes #2518.
ac8a29e
@TooTallNate TooTallNate Remove the old -DPLATFORM="mac" define, to prevent redefinition warni…
…ngs.
768b2fa
@bnoordhuis

Thanks Nathan, merged in 9ff86a2 and f2ba4ce.

@bnoordhuis bnoordhuis closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 11, 2012
  1. @TooTallNate

    Set `process.platform` to "darwin" on OS X.

    TooTallNate authored
    This is consistent with the old waf build system, and doesn't break old scripts
    that are expecting the value to be "darwin".
    
    Fixes #2518.
  2. @TooTallNate
This page is out of date. Refresh to see the latest.
Showing with 7 additions and 0 deletions.
  1. +7 −0 node.gyp
View
7 node.gyp
@@ -178,6 +178,13 @@
}],
[ 'OS=="mac"', {
'libraries': [ '-framework Carbon' ],
+ 'defines!': [
+ 'PLATFORM="mac"',
+ ],
+ 'defines': [
+ # we need to use node's preferred "darwin" rather than gyp's preferred "mac"
+ 'PLATFORM="darwin"',
+ ],
}],
[ 'OS=="linux"', {
'libraries': [
Something went wrong with that request. Please try again.