Navigation Menu

Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Google Javascript Style for "src/node.js" #255

Closed

Conversation

indutny
Copy link
Member

@indutny indutny commented Sep 2, 2010

I've modified src/node.js to be compatible with Google Javascript Style, and now it's passing Closure Linter in strict mode.
Also fixed variable declaration at: http://github.com/ry/node/blob/master/src/node.js#L550

@ry
Copy link

ry commented Sep 2, 2010

Cool! Can you start with a different file - say lib/http.js - one that doesn't requiring blowing out the indention across the entire file? I'd like to start slowly with this - at the very end if required we can do this src/node.js indention change.

Bonus points if you hook the lint command into the makefile for "make lint"

@indutny
Copy link
Member Author

indutny commented Sep 2, 2010

lib/http.js already done: http://github.com/ry/node/pull/256
Ok, I will fix makefile.

Anyway, I recommend you to fix this: http://github.com/ry/node/blob/master/src/node.js#L550

@indutny
Copy link
Member Author

indutny commented Sep 3, 2010

Ok, latest pull request is : http://github.com/ry/node/pull/257.
Closing this issue

@Sannis
Copy link

Sannis commented Sep 3, 2010

Ry, if you accept the use of Google Closure Linter, I think we need to update the wiki and popolarization its use by developers.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants