Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Include the node.lib file at link time on Windows. #2685

Closed
wants to merge 3 commits into from

2 participants

Nathan Rajlich Bert Belder
Nathan Rajlich
Owner

Makes the basic gyp_addon script work with Windows.

The "Debug" dir is currently hard-coded. A better way would be to use the currently selected "configuration" that gyp is executing, but I could not figure out how to get a variable of the configuration. If someone knows a way to get the Debug/Release value through gyp then that would be great.

Nathan Rajlich TooTallNate Include the node.lib file at link time on Windows.
Makes the basic `gyp_addon` script work with Windows.

The "Debug" dir is currently hard-coded. A better way would be to use
the currently selected "configuration" that gyp is executing, but I could not
figure out how to get a variable of the configuration...
43212f4
Bert Belder piscisaureus was assigned
Nathan Rajlich TooTallNate referenced this pull request in TooTallNate/node-gyp
Closed

Make Windows work #3

Nathan Rajlich
Owner

@piscisaureus Ok I have updated this to use the proper "Configuration" value, and not be hard-coded. Tested and works. Works with node-gyp as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 6, 2012
  1. Nathan Rajlich

    Include the node.lib file at link time on Windows.

    TooTallNate authored
    Makes the basic `gyp_addon` script work with Windows.
    
    The "Debug" dir is currently hard-coded. A better way would be to use
    the currently selected "configuration" that gyp is executing, but I could not
    figure out how to get a variable of the configuration...
Commits on Feb 6, 2012
  1. Nathan Rajlich
  2. Nathan Rajlich
This page is out of date. Refresh to see the latest.
Showing with 4 additions and 0 deletions.
  1. +3 −0  tools/addon.gypi
  2. +1 −0  tools/gyp_addon
3  tools/addon.gypi
View
@@ -12,6 +12,9 @@
'conditions': [
[ 'OS=="mac"', {
'libraries': [ '-undefined dynamic_lookup' ],
+ }],
+ [ 'OS=="win"', {
+ 'libraries': [ '-l<(node_root_dir)/$(Configuration)/node.lib' ],
}]
]
}
1  tools/gyp_addon
View
@@ -16,6 +16,7 @@ if __name__ == '__main__':
args.extend(['-I', common_gypi])
args.extend(['-Dlibrary=shared_library'])
args.extend(['-Dvisibility=default'])
+ args.extend(['-Dnode_root_dir=%s' % node_root])
args.extend(['--depth=.']);
gyp_args = list(args)
Something went wrong with that request. Please try again.