Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Feature inlined assembly returns #4139

Closed
wants to merge 7 commits into from
+22,874 −10,833

3 participants

@indutny
Owner

WIP

@indutny
Owner

tests are passing.

@piscisaureus

Good. So, bonus points for:

  • Making it link on solaris. Solaris has the picky-est linker of them all, it's a good test case.
  • Locating all the new (perl)asm files that were added from 1.0.0 -> 1.0.1 and deciding on them.
@indutny
Owner

[03:49|% 100|+ 480|- 2]: Done on solaris, looking at new files.

@indutny
Owner

It seems that I can't find any new assembly... so, @bnoordhuis @piscisaureus review please?

@indutny
Owner

Force pushed with some x86_64 fixes.

@indutny
Owner

@piscisaureus what is the status of this stuff?

@indutny
Owner
piscisaureus and others added some commits
@piscisaureus piscisaureus openssl: fix perlasm issue
When perlasm generates MASM code it sets the assembler target to 468.
In this mode MASM refuses to assemble the CPUID instruction. Bumping
the target to 586 solves this problem.
15830a0
@piscisaureus piscisaureus openssl: revert empty_OPENSSL_cpuid_setup.patch d04015f
@bnoordhuis bnoordhuis openssl: generate asm code with a Makefile 0fb03b0
@piscisaureus piscisaureus openssl: use optimized asm code on x86 and x64 3e5b404
@piscisaureus piscisaureus openssl: add 'clean' target to asm Makefile 5c82e5f
@piscisaureus piscisaureus openssl: disable HT sidechannel attack mitigation
It used to be off before. It's extremely unlikely that such an attack
would be a viable attack against node. And it makes AES much slower.
118aa33
@indutny indutny openssl: fix build ee73a66
@piscisaureus

Continues in #4441

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 19, 2012
  1. @piscisaureus @indutny

    openssl: fix perlasm issue

    piscisaureus authored indutny committed
    When perlasm generates MASM code it sets the assembler target to 468.
    In this mode MASM refuses to assemble the CPUID instruction. Bumping
    the target to 586 solves this problem.
  2. @piscisaureus @indutny

    openssl: revert empty_OPENSSL_cpuid_setup.patch

    piscisaureus authored indutny committed
  3. @bnoordhuis @indutny

    openssl: generate asm code with a Makefile

    bnoordhuis authored indutny committed
  4. @piscisaureus @indutny

    openssl: use optimized asm code on x86 and x64

    piscisaureus authored indutny committed
  5. @piscisaureus @indutny

    openssl: add 'clean' target to asm Makefile

    piscisaureus authored indutny committed
  6. @piscisaureus @indutny

    openssl: disable HT sidechannel attack mitigation

    piscisaureus authored indutny committed
    It used to be off before. It's extremely unlikely that such an attack
    would be a viable attack against node. And it makes AES much slower.
  7. @indutny

    openssl: fix build

    indutny authored
Something went wrong with that request. Please try again.