Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Clarify comment about URI auth in mailto host #4249

Open
wants to merge 1 commit into from

2 participants

@davidmurdoch

The previous comment was difficult to understand upon first read and had a few typos.

@davidmurdoch davidmurdoch Clarify comment about URI auth in mailto host
The previous comment was difficult to understand upon first read and had a few typos.
61312e9
@Nodejs-Jenkins

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 7, 2012
  1. @davidmurdoch

    Clarify comment about URI auth in mailto host

    davidmurdoch authored
    The previous comment was difficult to understand upon first read and had a few typos.
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 3 deletions.
  1. +3 −3 lib/url.js
View
6 lib/url.js
@@ -558,9 +558,9 @@ Url.prototype.resolveObject = function(relative) {
// Put this after the other two cases because it simplifies the booleans
if (psychotic) {
result.hostname = result.host = srcPath.shift();
- //occationaly the auth can get stuck only in host
- //this especialy happens in cases like
- //url.resolveObject('mailto:local1@domain1', 'local2@domain2')
+ // the auth part may be found within the host in some cases.
+ // example:
+ // url.resolveObject('mailto:local1@domain1', 'local2@domain2')
var authInHost = result.host && result.host.indexOf('@') > 0 ?
result.host.split('@') : false;
if (authInHost) {
Something went wrong with that request. Please try again.