Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix build on Raspberry Pi #4534

Closed
wants to merge 1 commit into from

3 participants

Ing. Jan Kaláb Ben Noordhuis Nathan Rajlich
Ing. Jan Kaláb

See issue #4142!
Builds fine on v0.8 branch.
Values taken from standalone.gypi.

Ing. Jan Kaláb Fix build on Raspberry Pi
See issue 4142!
Build fine on v0.8 branch.
Values taken from standalone.gypi.
bd24932
Ing. Jan Kaláb

git bisect, 7b4d95a is the breaking commit!

Ben Noordhuis

Please see the CONTRIBUTING guide, we don't take V8 patches. If you can get it to work by tweaking the configure script, I'll be happy to merge it.

Nathan Rajlich TooTallNate referenced this pull request from a commit in TooTallNate/node
Nathan Rajlich TooTallNate configure: on ARM, always define the "arm_fpu" and "arm_neon" variables
v8's common.gypi file expects them to be defined now.
See: #4534
4f4c5a0
Nathan Rajlich
Owner

Can somebody (preferably @bnoordhuis) review TooTallNate/node@4f4c5a0?

Nathan Rajlich TooTallNate closed this pull request from a commit
Nathan Rajlich TooTallNate configure: define "arm_fpu" and "arm_neon" for ARM
v8's common.gypi file expects them to be defined now.

Closes #4534.
b916774
Nathan Rajlich
Owner

@Pitel Thanks for the report. Fixed in b916774.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 8, 2013
  1. Fix build on Raspberry Pi

    Ing. Jan Kaláb authored
    See issue 4142!
    Build fine on v0.8 branch.
    Values taken from standalone.gypi.
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 0 deletions.
  1. +2 −0  deps/v8/build/common.gypi
2  deps/v8/build/common.gypi
View
@@ -50,6 +50,8 @@
# probing when running on the target.
'v8_can_use_vfp2_instructions%': 'false',
'v8_can_use_vfp3_instructions%': 'false',
+ 'arm_neon%': 0,
+ 'arm_fpu%': 'vfpv3',
# Similar to vfp but on MIPS.
'v8_can_use_fpu_instructions%': 'true',
Something went wrong with that request. Please try again.