Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add an npm link above the homepage fold #5203

Closed
wants to merge 1 commit into from

3 participants

Joe Wegner Nodejs Jenkins isaacs
Joe Wegner

Well, to be honest, I'm a bit nervous to actually start contributing to core, so I thought I'd wean myself on by doing some bitesize/website stuff.

So, here it is. I'm by no means a designer, so it might not be perfect, but it's a practice pull request anyways.

Fixes joyent/node#4077.

Nodejs Jenkins

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit josephwegner/node@63173b0 has the following error(s):

  • Commit message must indicate the subsystem this commit changes

Please see CONTRIBUTING.md for more information

Joe Wegner josephwegner web: Add an npm link above the homepage fold
Add a third button underneath the INSTALL button that links
to http://search.npmjs.org

Fixes joyent/node#4077.
8e3ad30
Joe Wegner

Sorry Jenkins. Not sure if "web" is really a subsystem, but hopefully that works.

By the way, I HAVE already filled out the CLA

isaacs
Owner

@josephwegner Don't mind @Nodejs-Jenkins, he's just upset because he can never be a real boy.

Please don't be discouraged, but I don't think this patch is a good idea. We've tried to keep the "download" and "install" section as un-cluttered as we can get away with, and adding another button is a step back.

But now you've been through the process, so if you ever find a bug or want to fix some documentation, you've got nothing stopping you :)

isaacs isaacs closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 2, 2013
  1. Joe Wegner

    web: Add an npm link above the homepage fold

    josephwegner authored
    Add a third button underneath the INSTALL button that links
    to http://search.npmjs.org
    
    Fixes joyent/node#4077.
This page is out of date. Refresh to see the latest.
Showing with 6 additions and 5 deletions.
  1. +3 −2 doc/index.html
  2. +3 −3 doc/pipe.css
5 doc/index.html
View
@@ -28,8 +28,9 @@
<div class=buttons>
<a href="http://nodejs.org/dist/__VERSION__/node-__VERSION__.tar.gz" class="button downloadbutton" id="downloadbutton">INSTALL</a>
- <a href="download/" class=button id="all-dl-options">Downloads</a
- ><a href="api/" class="button" id="docsbutton">API Docs</a>
+ <a href="download/" class=button id="all-dl-options">Downloads</a>
+ <a href="api/" class="button" id="docsbutton">API Docs</a>
+ <a href="http://search.npmjs.org" class="button" id="npmbutton">NPM</a>
</div>
<a href="http://github.com/joyent/node"><img class="forkme" src="http://nodejs.org/images/forkme.png" alt="Fork me on GitHub"></a>
6 doc/pipe.css
View
@@ -101,7 +101,7 @@ h1 a, h2 a, h3 a, h4 a {
height: auto;
overflow: hidden;
_zoom: 1;
- width: 300px;
+ width: 350px;
margin: 0 auto;
}
@@ -120,7 +120,7 @@ h1 a, h2 a, h3 a, h4 a {
-moz-transition: .2s all ease-in-out;
transition: .2s all ease-in-out;
- margin: 10px 4px;
+ margin: 8px 1px;
display: inline-block;
color: #46483e;
background-color: #9a9f8b;
@@ -145,7 +145,7 @@ h1 a, h2 a, h3 a, h4 a {
#intro .downloadbutton {
background-color: #8BC84B;
- width: 200px;
+ width: 300px;
font-size: 14px;
font-weight: bold;
display: block;
Something went wrong with that request. Please try again.