Skip to content
This repository

v8: backport r18035 into current version, fixing v8 build on freebsd #7021

Closed
wants to merge 1 commit into from

4 participants

Chilledheart Nodejs Jenkins Trevor Norris Timothy J Fontaine
Chilledheart

the lines below are the same with #7020

When hacking with node, i got a build error (built on freebsd)

../deps/v9/src/platform-freebsd.cc:185:62: error: too few arguments provided to function-like macro invocation
    LOG(isolate SharedLibraryEvent(start_of_path, start, end));
                                                             ^
../deps/v8/src/log.h:86:9: note: macro 'LOG' defined here
#define LOG(isolate, Call)                          \
        ^
../deps/v8/src/platform-freebsd.cc:185:5: error: use of undeclared identifier 'LOG'
    LOG(isolate SharedLibraryEvent(start_of_path, start, end));
    ^
2 errors generated.
gmake[1]: *** [/usr/home/bsd/node/out/Release/obj.target/v8_base.x64/deps/v8/src/platform-freebsd.o] Error 1
gmake[1]: *** Waiting for unfinished jobs....
gmake[1]: Leaving directory `/usr/home/bsd/node/out'
gmake: *** [node] Error 2

It's obvious a mistype in deps/v8/src/platform-freebsd.cc, at LINE 186:

LOG(isolate SharedLibraryEvent(start_of_path, start, end));

which should be something like:

LOG(isolate, SharedLibraryEvent(start_of_path, start, end));

A comma is missing here :-P.

related issue in v8, which is fixed in r18035.

If there is any plan to backport the patch, I really appreciate it.

Nodejs Jenkins
Collaborator

Thank you for contributing this pull request! Here are a few pointers to make sure your submission will be considered for inclusion.

Commit Chilledheart/node@5443a9e has the following error(s):

  • First line of commit message must be no longer than 50 characters

The following commiters were not found in the CLA:

  • Chilledheart

You can fix all these things without opening another issue.

Please see CONTRIBUTING.md for more information

Trevor Norris
Collaborator

@tjfontaine assigning this to you.

erm... it was already assigned to you.

Timothy J Fontaine tjfontaine referenced this pull request from a commit
Ben Noordhuis bnoordhuis v8: unbreak freebsd build
reland de8c0a5

Fixes #7020 and #7021
3421d29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. +1 1  deps/v8/src/platform-freebsd.cc
2  deps/v8/src/platform-freebsd.cc
@@ -182,7 +182,7 @@ void OS::LogSharedLibraryAddresses(Isolate* isolate) {
182 182 // There may be no filename in this line. Skip to next.
183 183 if (start_of_path == NULL) continue;
184 184 buffer[bytes_read] = 0;
185   - LOG(isolate SharedLibraryEvent(start_of_path, start, end));
  185 + LOG(isolate, SharedLibraryEvent(start_of_path, start, end));
186 186 }
187 187 close(fd);
188 188 }

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.